Bug 185052

Summary: [Cocoa] Set HTTPOnly flag when converting Cookie to NSHTTPCookie
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: WebKit APIAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, ews-watchlist, ggaren, sihui_liu, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews117 for mac-sierra none

Sihui Liu
Reported 2018-04-26 14:53:33 PDT
We didn't set the HTTPOnly flag when converting from Cookie to NSHTTPCookie, so the NSHTTPCookie returned by [WKHTTPCookieStore getAllCookies] would always be marked as not HTTPOnly.
Attachments
Patch (10.39 KB, patch)
2018-04-27 17:17 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews117 for mac-sierra (3.16 MB, application/zip)
2018-04-27 18:59 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2018-04-27 17:17:59 PDT
Created attachment 339042 [details] Patch
EWS Watchlist
Comment 2 2018-04-27 18:59:06 PDT
Comment on attachment 339042 [details] Patch Attachment 339042 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7486602 New failing tests: svg/custom/object-sizing-explicit-width.xhtml
EWS Watchlist
Comment 3 2018-04-27 18:59:07 PDT
Created attachment 339048 [details] Archive of layout-test-results from ews117 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6
Geoffrey Garen
Comment 4 2018-04-28 22:00:41 PDT
Comment on attachment 339042 [details] Patch r=me Hard to tell whether this is an EWS pass or fail. mac-debug looks like a pass, with some pre-existing failures. gtk-wk2 and woe look like the builder needs a reboot. So, I'll say cq+.
WebKit Commit Bot
Comment 5 2018-04-28 22:26:45 PDT
Comment on attachment 339042 [details] Patch Clearing flags on attachment: 339042 Committed r231146: <https://trac.webkit.org/changeset/231146>
WebKit Commit Bot
Comment 6 2018-04-28 22:26:46 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-04-28 22:27:26 PDT
<rdar://problem/39821948>
Note You need to log in before you can comment on or make changes to this bug.