Bug 185049

Summary: [WinCairo] Support --no-copy for jsc tests in wincairo tests, add copying of dlls for copy case
Product: WebKit Reporter: Stephan Szabo <stephan.szabo>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, jfbastien, keith_miller, ross.kirsling, webkit-bug-importer, ysuzuki, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
keith_miller: review+
Extraneous whitespace removed
none
Archive of layout-test-results from webkit-cq-02 for mac-sierra none

Stephan Szabo
Reported 2018-04-26 14:30:47 PDT
[WinCairo] Support --no-copy for jsc tests in wincairo tests, add copying of dlls for copy case
Attachments
Patch (5.19 KB, patch)
2018-04-26 14:35 PDT, Stephan Szabo 		keith_miller: review+
DetailsFormatted DiffDiff
Extraneous whitespace removed (4.93 KB, patch)
2018-04-27 14:27 PDT, Stephan Szabo 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-cq-02 for mac-sierra (1.21 MB, application/zip)
2018-04-27 15:21 PDT, WebKit Commit Bot 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Stephan Szabo
Comment 1 2018-04-26 14:35:15 PDT
Created attachment 338916 [details] Patch
Stephan Szabo
Comment 2 2018-04-26 14:40:22 PDT
When setting up the wincairo test machines, we ran into some problems running the JSC tests because previously we had been testing jsc-only windows builds, but those are static JavaScriptCore and WTF, so the necessary DLLs weren't being copied. While doing that, it was suggested internally that not copying might be better, so added path to allow --no-copy to go from run-javascriptcore-tests to run-jsc-stress-tests and used the jsc location if no framework location was found.
Keith Miller
Comment 3 2018-04-27 14:14:47 PDT
Comment on attachment 338916 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338916&action=review seems reasonable. r=me with some comments. > Tools/Scripts/run-jsc-stress-tests:1581 > + if !$remote and !$tarball Nit: Please remove this whitespace?
Stephan Szabo
Comment 4 2018-04-27 14:27:44 PDT
Created attachment 339027 [details] Extraneous whitespace removed Thanks for pointing out the extra whitespace, this is the same patch it trimmed.
WebKit Commit Bot
Comment 5 2018-04-27 15:21:34 PDT
Comment on attachment 339027 [details] Extraneous whitespace removed Rejecting attachment 339027 [details] from commit-queue. Number of test failures exceeded the failure limit. Full output: http://webkit-queues.webkit.org/results/7484944
WebKit Commit Bot
Comment 6 2018-04-27 15:21:36 PDT
Created attachment 339034 [details] Archive of layout-test-results from webkit-cq-02 for mac-sierra The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-02 Port: mac-sierra Platform: Mac OS X 10.12.6
WebKit Commit Bot
Comment 7 2018-04-27 17:22:00 PDT
Comment on attachment 339027 [details] Extraneous whitespace removed Clearing flags on attachment: 339027 Committed r231122: <https://trac.webkit.org/changeset/231122>
WebKit Commit Bot
Comment 8 2018-04-27 17:22:02 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-04-27 17:23:25 PDT
<rdar://problem/39810172>
Note You need to log in before you can comment on or make changes to this bug.