Bug 185037

Summary: Remove WebCore::-qualifier in NetworkLoadChecker.cpp
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebKit Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, beidson, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch youennf: review+

Daniel Bates
Reported 2018-04-26 11:34:08 PDT
Notice that NetworkLoadChecker.cpp as a "using namespace WebCore" at the top of the file. It is unnecessary to qualify WebCore types following this directive.
Attachments
Patch (4.27 KB, patch)
2018-04-26 11:36 PDT, Daniel Bates 		youennf: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2018-04-26 11:36:00 PDT
Created attachment 338899 [details] Patch
Daniel Bates
Comment 2 2018-04-26 11:37:17 PDT
Comment on attachment 338899 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338899&action=review > Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp:183 > + m_storedCredentialsPolicy = m_isSameOriginRequest && m_origin->canRequest(request.url()) ? StoredCredentialsPolicy::Use : StoredCredentialsPolicy::DoNotUse; Will add a remark about this change in the ChangeLog before landing. While I was here I noticed there was an extra space character on the right-hand side of the assignment and the parentheses are not necessary in the right-hand side of the assignment.
Daniel Bates
Comment 3 2018-04-26 11:42:13 PDT
Committed r231060: <https://trac.webkit.org/changeset/231060>
Radar WebKit Bug Importer
Comment 4 2018-04-26 11:43:24 PDT
<rdar://problem/39765096>
Note You need to log in before you can comment on or make changes to this bug.