Bug 185017

Summary:

Activate selection when interacting with editable content

Product:

WebKit

Reporter:

Megan Gardner <megan_gardner>

Component:

New Bugs

Assignee:

Megan Gardner <megan_gardner>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, ews-watchlist, sam, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	thorton: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews200 for win-future	none

Megan Gardner

Reported 2018-04-25 17:18:01 PDT

Activate selection when interacting with editable content

Attachments
Patch (1.98 KB, patch) 2018-04-25 17:22 PDT, Megan Gardner	no flags	Details Formatted Diff Diff
Patch (17.22 KB, patch) 2018-04-25 20:08 PDT, Megan Gardner	thorton: review+ ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews200 for win-future (12.65 MB, application/zip) 2018-04-26 00:28 PDT, EWS Watchlist	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Megan Gardner

Comment 1 2018-04-25 17:22:26 PDT

Created attachment 338833 [details] Patch

Radar WebKit Bug Importer

Comment 2 2018-04-25 17:26:29 PDT

<rdar://problem/39741847>

Sam Weinig

Comment 3 2018-04-25 17:26:37 PDT

Where are we on being able to test this stuff?

Radar WebKit Bug Importer

Comment 4 2018-04-25 17:29:24 PDT

<rdar://problem/39741913>

Radar WebKit Bug Importer

Comment 5 2018-04-25 17:31:50 PDT

<rdar://problem/39741857>

Wenson Hsieh

Comment 6 2018-04-25 17:50:23 PDT

Comment on attachment 338833 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338833&action=review This looks like a reasonable change to me. It would be great to have a test... Probably not for this patch, but we should really rename -useSelectionAssistantWithGranularity: to -ensureTextSelectionAssistant or something similar, and drop the selectionGranularity argument. > Source/WebKit/ChangeLog:10 > + This fulfills the requirement of user interaction as well, so any javascript selecitons Nit - selections

Megan Gardner

Comment 7 2018-04-25 20:08:05 PDT

Created attachment 338852 [details] Patch

EWS Watchlist

Comment 8 2018-04-26 00:27:51 PDT

Comment on attachment 338852 [details] Patch Attachment 338852 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7465083 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html

EWS Watchlist

Comment 9 2018-04-26 00:28:02 PDT

Created attachment 338862 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Tim Horton

Comment 10 2018-04-26 10:53:10 PDT

Comment on attachment 338852 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338852&action=review > LayoutTests/fast/events/touch/ios/double-tap-on-editable-content-for-selection-then-drag-right-to-change-selected-text.html:12 > + //setTimeout(function(){testRunner.notifyDone()},2000); What's this! > LayoutTests/fast/events/touch/ios/double-tap-on-editable-content-for-selection-then-drag-right-to-change-selected-text.html:90 > + var editableElement =document.getElementById('editable'); Space after = :P

Megan Gardner

Comment 11 2018-04-26 11:05:57 PDT

https://trac.webkit.org/r231054

Note You need to log in before you can comment on or make changes to this bug.