Bug 184999

Summary: Missing closing parenthesis when determining INSTALL_PATH build setting in WebCore.xcconfig
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit Misc.Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mitz, thorton, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Wenson Hsieh
Reported 2018-04-25 13:37:34 PDT
This doesn't appear to have any impact, since the resulting build settings are the same before and after the change (using `xcodebuild -showBuildSettings`). Just a bit of tidying.
Attachments
Patch (1.80 KB, patch)
2018-04-25 13:40 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch (2.06 KB, patch)
2018-04-25 14:21 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2018-04-25 13:40:43 PDT
Created attachment 338784 [details] Patch
Tim Horton
Comment 2 2018-04-25 13:51:54 PDT
Comment on attachment 338784 [details] Patch Why is this not just using WK_COCOA_TOUCH the normal way? Why all this notting and emptying?
Wenson Hsieh
Comment 3 2018-04-25 13:59:37 PDT
(In reply to Tim Horton from comment #2) > Comment on attachment 338784 [details] > Patch > > Why is this not just using WK_COCOA_TOUCH the normal way? Why all this > notting and emptying? Good point...perhaps it should be something like this? INSTALL_PATH = $(INSTALL_PATH_$(WK_COCOA_TOUCH)); INSTALL_PATH_cocoatouch = $(WK_ALTERNATE_WEBKIT_SDK_PATH)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks; INSTALL_PATH_ = $(WEBCORE_FRAMEWORKS_DIR);
Tim Horton
Comment 4 2018-04-25 14:14:07 PDT
Yes
Wenson Hsieh
Comment 5 2018-04-25 14:21:13 PDT
Created attachment 338791 [details] Patch
WebKit Commit Bot
Comment 6 2018-04-25 16:23:06 PDT
Comment on attachment 338791 [details] Patch Clearing flags on attachment: 338791 Committed r231032: <https://trac.webkit.org/changeset/231032>
WebKit Commit Bot
Comment 7 2018-04-25 16:23:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.