Bug 184999

Summary: Missing closing parenthesis when determining INSTALL_PATH build setting in WebCore.xcconfig
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit Misc.Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mitz, thorton, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Wenson Hsieh 2018-04-25 13:37:34 PDT 
This doesn't appear to have any impact, since the resulting build settings are the same before and after the change (using `xcodebuild -showBuildSettings`).

Just a bit of tidying.
Comment 1 Wenson Hsieh 2018-04-25 13:40:43 PDT 
Created attachment 338784 [details]
Patch
Comment 2 Tim Horton 2018-04-25 13:51:54 PDT 
Comment on attachment 338784 [details]
Patch

Why is this not just using WK_COCOA_TOUCH the normal way? Why all this notting and emptying?
Comment 3 Wenson Hsieh 2018-04-25 13:59:37 PDT 
(In reply to Tim Horton from comment #2)
> Comment on attachment 338784 [details]
> Patch
> 
> Why is this not just using WK_COCOA_TOUCH the normal way? Why all this
> notting and emptying?

Good point...perhaps it should be something like this?

INSTALL_PATH = $(INSTALL_PATH_$(WK_COCOA_TOUCH));
INSTALL_PATH_cocoatouch = $(WK_ALTERNATE_WEBKIT_SDK_PATH)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks;
INSTALL_PATH_ = $(WEBCORE_FRAMEWORKS_DIR);
Comment 4 Tim Horton 2018-04-25 14:14:07 PDT 
Yes
Comment 5 Wenson Hsieh 2018-04-25 14:21:13 PDT 
Created attachment 338791 [details]
Patch
Comment 6 WebKit Commit Bot 2018-04-25 16:23:06 PDT 
Comment on attachment 338791 [details]
Patch

Clearing flags on attachment: 338791

Committed r231032: <https://trac.webkit.org/changeset/231032>
Comment 7 WebKit Commit Bot 2018-04-25 16:23:07 PDT 
All reviewed patches have been landed.  Closing bug.