Summary: | [WPE] Should load injected bundle from builddir in developer builds | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> | ||||
Component: | WebKitGTK | Assignee: | Michael Catanzaro <mcatanzaro> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bugs-noreply, clopez, commit-queue, mcatanzaro, pnormand | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Michael Catanzaro
2018-04-25 11:12:07 PDT
Not a problem for GTK. GTK MiniBrowser uses WEBKIT_INJECTED_BUNDLE_PATH to control this. Created attachment 338777 [details]
Patch
Comment on attachment 338777 [details] Patch Clearing flags on attachment: 338777 Committed r231021: <https://trac.webkit.org/changeset/231021> All reviewed patches have been landed. Closing bug. Why is LD_LIBRARY_PATH set only for WPE? (In reply to Philippe Normand from comment #5) > Why is LD_LIBRARY_PATH set only for WPE? It should not be needed because for ELF binaries, CMake sets rpath to point to the build directory when linking (and then zeros it at install time). Otherwise, nothing built by CMake would work before it's installed. |