Bug 184976

Summary:

Push the definition of PtrTag down to the WTF layer.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, dbates, ews-watchlist, fpizlo, jfbastien, keith_miller, msaboff, rmorisset, ryanhaddad, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch.	saam: review+
patch for landing + CMake fixes.	none

Description Mark Lam 2018-04-25 09:43:42 PDT

This is in preparation for doing pointer profiling at the WTF later as well.

Comment 1 Radar WebKit Bug Importer 2018-04-25 09:44:52 PDT

<rdar://problem/39723901>

Comment 2 Mark Lam 2018-04-25 12:57:44 PDT

Created attachment 338772 [details]
proposed patch.

Comment 3 Mark Lam 2018-04-25 13:39:20 PDT

Created attachment 338783 [details]
patch for landing + CMake fixes.

Comment 4 Mark Lam 2018-04-25 15:32:03 PDT

Thanks for the review.  Landed in r231027: <http://trac.webkit.org/r231027>.

Comment 5 Ryan Haddad 2018-04-25 15:57:59 PDT

This change broke the Windows build:

c:\cygwin\home\buildbot\slave\win-debug\build\source\javascriptcore\runtime\JSCPtrTag.h(56): error C2220: warning treated as error - no 'object' file generated [C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\Source\JavaScriptCore\LLIntOffsetsExtractor.vcxproj]
c:\cygwin\home\buildbot\slave\win-debug\build\source\javascriptcore\runtime\JSCPtrTag.h(56): warning C4307: '*': integral constant overflow [C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\Source\JavaScriptCore\LLIntOffsetsExtractor.vcxproj]
c:\cygwin\home\buildbot\slave\win-debug\build\source\javascriptcore\runtime\JSCPtrTag.h(56): warning C4307: '+': integral constant overflow [C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\Source\JavaScriptCore\LLIntOffsetsExtractor.vcxproj]

https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/8648

Comment 6 Mark Lam 2018-04-25 17:14:26 PDT

Landed a speculative build fix for 32-bit Windows in r231035: <http://trac.webkit.org/r231035>.

Comment 7 Mark Lam 2018-04-26 16:00:04 PDT

(In reply to Mark Lam from comment #6)
> Landed a speculative build fix for 32-bit Windows in r231035:
> <http://trac.webkit.org/r231035>.

New revised speculative build fix for Windows landed in r231079: <http://trac.webkit.org/r231079>.