Bug 184973

Summary:	[OpenVR] CMake options exposed to users
Product:	WebKit	Reporter:	Michael Catanzaro <mcatanzaro>
Component:	WebKitGTK	Assignee:	Nobody <webkit-unassigned>
Status:	NEW ---
Severity:	Normal	CC:	annulen, bugs-noreply, mcatanzaro, svillar
Priority:	P2
Version:	WebKit Nightly Build
Hardware:	PC
OS:	Linux

Description Michael Catanzaro 2018-04-25 09:17:40 PDT

Splitting this out from bug #184972:

The OpenVR build options BUILD_SHARED, USE_LIBCXX, and USE_CUSTOM_LIBCXX are all currently exposed to users building WebKit. I don't think any openvr options should be exposed, because they look like normal WebKit options and there's not really any way to know that they're not. So I would mark these all as advanced. But then there's not really any point of keeping the options at all, right? That seems to indicate that the options should be removed. Sergio, what do you think we should do here? At the least, I would mark them all as advanced.

Comment 1 Konstantin Tokarev 2018-04-25 09:44:00 PDT

In case you are wondering how to avoid exporting these options, I know 2 ways:
* Remove option() calls in 3rd-party cmake files
* Build 3rd party cmake projects via ExternalProject instead of including their project files into our build system (which may result in other side effects as well, e.g. changing global variables)

Comment 2 Michael Catanzaro 2018-04-25 12:53:49 PDT

(In reply to Konstantin Tokarev from comment #1)
> * Build 3rd party cmake projects via ExternalProject instead of including
> their project files into our build system (which may result in other side
> effects as well, e.g. changing global variables)

That sounds intriguing. At least it would reduce the need to patch OpenVR so much.