Bug 184972

Summary: [CMake] Some options should be marked as advanced
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: Tools / TestsAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, commit-queue, lforschler, mcatanzaro, svillar, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2018-04-25 08:44:12 PDT
There are also a couple build options that should be advanced, but are not. BUILD_SHARED is definitely not going to work. LIBGCRYPTCONFIG_SCRIPT and the WEBP options should also be advanced. I'm not sure about USE_CUSTOM_LIBCXX and USE_LIBCXX.
Attachments
Patch (2.02 KB, patch)
2018-04-25 09:19 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2018-04-25 09:18:07 PDT
Let's handle BUILD_SHARED, USE_CUSTOM_LIBCXX, and USE_LIBCXX in bug #184973
Michael Catanzaro
Comment 2 2018-04-25 09:19:53 PDT
Created attachment 338744 [details] Patch
WebKit Commit Bot
Comment 3 2018-04-25 12:58:59 PDT
Comment on attachment 338744 [details] Patch Clearing flags on attachment: 338744 Committed r231012: <https://trac.webkit.org/changeset/231012>
WebKit Commit Bot
Comment 4 2018-04-25 12:59:00 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-04-25 12:59:18 PDT
<rdar://problem/39731293>
Note You need to log in before you can comment on or make changes to this bug.