Bug 184960

Summary:

Fix entitlements and sandbox configurations in WebKit after r230778

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

WebKit Misc.

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dbates, jer.noble, saam, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review-
Patch	none
Patch for landing	none
Patch	none

Wenson Hsieh

Reported 2018-04-24 23:32:49 PDT

<rdar://problem/39662827>

Attachments
Patch (4.10 KB, patch) 2018-04-24 23:34 PDT, Wenson Hsieh	thorton: review-	Details Formatted Diff Diff
Patch (4.17 KB, patch) 2018-04-25 07:31 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Patch for landing (4.24 KB, patch) 2018-04-25 12:28 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Patch (2.82 KB, patch) 2018-05-03 00:48 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Wenson Hsieh

Comment 1 2018-04-24 23:34:46 PDT

Created attachment 338711 [details] Patch

Wenson Hsieh

Comment 2 2018-04-25 00:41:06 PDT

Comment on attachment 338711 [details] Patch Oops..it seems the recommended way of doing this is to augment the _BASE config instead (e.g. WK_XPC_SERVICE_IOS_ENTITLEMENTS_BASE_… = …).

Wenson Hsieh

Comment 3 2018-04-25 07:31:25 PDT

Created attachment 338735 [details] Patch

Tim Horton

Comment 4 2018-04-25 12:20:53 PDT

Comment on attachment 338735 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338735&action=review > Source/WebKit/Configurations/BaseXPCService.xcconfig:59 > +CODE_SIGN_ENTITLEMENTS_watchos = $(CODE_SIGN_ENTITLEMENTS_IOS_SKIP_INSTALL_$(SKIP_INSTALL)); This one can use WK_COCOA_TOUCH

Wenson Hsieh

Comment 5 2018-04-25 12:28:02 PDT

(In reply to Tim Horton from comment #4) > Comment on attachment 338735 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=338735&action=review > > > Source/WebKit/Configurations/BaseXPCService.xcconfig:59 > > +CODE_SIGN_ENTITLEMENTS_watchos = $(CODE_SIGN_ENTITLEMENTS_IOS_SKIP_INSTALL_$(SKIP_INSTALL)); > > This one can use WK_COCOA_TOUCH Indeed — changed to use WK_COCOA_TOUCH. Thanks for the review!

Wenson Hsieh

Comment 6 2018-04-25 12:28:22 PDT

Created attachment 338769 [details] Patch for landing

WebKit Commit Bot

Comment 7 2018-04-25 13:13:29 PDT

Comment on attachment 338769 [details] Patch for landing Clearing flags on attachment: 338769 Committed r231014: <https://trac.webkit.org/changeset/231014>

Wenson Hsieh

Comment 8 2018-05-03 00:33:25 PDT

Comment on attachment 338735 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338735&action=review >>> Source/WebKit/Configurations/BaseXPCService.xcconfig:59 >>> +CODE_SIGN_ENTITLEMENTS_watchos = $(CODE_SIGN_ENTITLEMENTS_IOS_SKIP_INSTALL_$(SKIP_INSTALL)); >> >> This one can use WK_COCOA_TOUCH > > Indeed — changed to use WK_COCOA_TOUCH. > > Thanks for the review! .......on second thought, changing to use WK_COCOA_TOUCH here means that CODE_SIGN_ENTITLEMENTS_macos won't apply anymore, since CODE_SIGN_ENTITLEMENTS is no longer $(CODE_SIGN_ENTITLEMENTS_$(WK_PLATFORM_NAME))

Tim Horton

Comment 9 2018-05-03 00:39:58 PDT

(In reply to Wenson Hsieh from comment #8) > Comment on attachment 338735 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=338735&action=review > > >>> Source/WebKit/Configurations/BaseXPCService.xcconfig:59 > >>> +CODE_SIGN_ENTITLEMENTS_watchos = $(CODE_SIGN_ENTITLEMENTS_IOS_SKIP_INSTALL_$(SKIP_INSTALL)); > >> > >> This one can use WK_COCOA_TOUCH > > > > Indeed — changed to use WK_COCOA_TOUCH. > > > > Thanks for the review! > > .......on second thought, changing to use WK_COCOA_TOUCH here means that > CODE_SIGN_ENTITLEMENTS_macos won't apply anymore, since > CODE_SIGN_ENTITLEMENTS is no longer > $(CODE_SIGN_ENTITLEMENTS_$(WK_PLATFORM_NAME)) Right, it ends up being CODE_SIGN_ENTITLEMENTS_ = ... See also Jer’s IS_COCOA_TOUCH thing. There’s been a whole debate about this

Wenson Hsieh

Comment 10 2018-05-03 00:48:24 PDT

Created attachment 339396 [details] Patch

Wenson Hsieh

Comment 11 2018-05-03 01:00:03 PDT

Comment on attachment 339396 [details] Patch Obsoleting — there's a better way to do this using WK_IS_COCOA_TOUCH.

Tim Horton

Comment 12 2018-05-03 02:08:35 PDT

I did that in https://bugs.webkit.org/show_bug.cgi?id=185241

Note You need to log in before you can comment on or make changes to this bug.