Bug 184949

Summary: visitedDependentColor() should take a CSSPropertyID
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Severity: Normal CC: commit-queue, koivisto, sam, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch none

Description Simon Fraser (smfr) 2018-04-24 18:06:38 PDT
visitedDependentColor() should take a CSSPropertyID
Comment 1 Simon Fraser (smfr) 2018-04-24 18:07:58 PDT
Created attachment 338693 [details]
Comment 2 Sam Weinig 2018-04-24 18:18:13 PDT
Comment on attachment 338693 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=338693&action=review

> Source/WebCore/rendering/RenderTableCell.cpp:562
> +    CSSPropertyID startColorProperty = includeColor ? CSSProperty::resolveDirectionAwareProperty(CSSPropertyWebkitBorderStartColor, styleForCellFlow().direction(), styleForCellFlow().writingMode()) : CSSPropertyInvalid;
> +    CSSPropertyID endColorProperty = includeColor ? CSSProperty::resolveDirectionAwareProperty(CSSPropertyWebkitBorderEndColor, styleForCellFlow().direction(), styleForCellFlow().writingMode()) : CSSPropertyInvalid;

You could maybe use auto here (and below), but it's up to you.
Comment 3 WebKit Commit Bot 2018-04-24 18:51:55 PDT
Comment on attachment 338693 [details]

Clearing flags on attachment: 338693

Committed r230979: <https://trac.webkit.org/changeset/230979>
Comment 4 WebKit Commit Bot 2018-04-24 18:51:56 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-04-24 18:52:16 PDT