Bug 184949

Summary: visitedDependentColor() should take a CSSPropertyID
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, koivisto, sam, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Simon Fraser (smfr)
Reported 2018-04-24 18:06:38 PDT
visitedDependentColor() should take a CSSPropertyID
Attachments
Patch (10.29 KB, patch)
2018-04-24 18:07 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2018-04-24 18:07:58 PDT
Created attachment 338693 [details] Patch
Sam Weinig
Comment 2 2018-04-24 18:18:13 PDT
Comment on attachment 338693 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338693&action=review > Source/WebCore/rendering/RenderTableCell.cpp:562 > + CSSPropertyID startColorProperty = includeColor ? CSSProperty::resolveDirectionAwareProperty(CSSPropertyWebkitBorderStartColor, styleForCellFlow().direction(), styleForCellFlow().writingMode()) : CSSPropertyInvalid; > + CSSPropertyID endColorProperty = includeColor ? CSSProperty::resolveDirectionAwareProperty(CSSPropertyWebkitBorderEndColor, styleForCellFlow().direction(), styleForCellFlow().writingMode()) : CSSPropertyInvalid; You could maybe use auto here (and below), but it's up to you.
WebKit Commit Bot
Comment 3 2018-04-24 18:51:55 PDT
Comment on attachment 338693 [details] Patch Clearing flags on attachment: 338693 Committed r230979: <https://trac.webkit.org/changeset/230979>
WebKit Commit Bot
Comment 4 2018-04-24 18:51:56 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-04-24 18:52:16 PDT
<rdar://problem/39707298>
Note You need to log in before you can comment on or make changes to this bug.