| Summary: | visitedDependentColor() should take a CSSPropertyID | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, koivisto, sam, simon.fraser, webkit-bug-importer, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2018-04-24 18:06:38 PDT
Created attachment 338693 [details]
Patch
Comment on attachment 338693 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338693&action=review > Source/WebCore/rendering/RenderTableCell.cpp:562 > + CSSPropertyID startColorProperty = includeColor ? CSSProperty::resolveDirectionAwareProperty(CSSPropertyWebkitBorderStartColor, styleForCellFlow().direction(), styleForCellFlow().writingMode()) : CSSPropertyInvalid; > + CSSPropertyID endColorProperty = includeColor ? CSSProperty::resolveDirectionAwareProperty(CSSPropertyWebkitBorderEndColor, styleForCellFlow().direction(), styleForCellFlow().writingMode()) : CSSPropertyInvalid; You could maybe use auto here (and below), but it's up to you. Comment on attachment 338693 [details] Patch Clearing flags on attachment: 338693 Committed r230979: <https://trac.webkit.org/changeset/230979> All reviewed patches have been landed. Closing bug. |