Bug 184935

Summary:

Serialize all URLs with double-quotes per CSSOM spec

Product:

WebKit

Reporter:

Chris Nardi <cnardi>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, koivisto, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews101 for mac-sierra	none
Update tests	ews-watchlist: commit-queue-
Archive of layout-test-results from ews103 for mac-sierra	none
Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews100 for mac-sierra	none
Update additional tests	none
Additional test fixes	none
Archive of layout-test-results from ews200 for win-future	none
Update Win expectation	none
Try rebasing	none

Chris Nardi

Reported 2018-04-24 14:07:34 PDT

Serialize all URLs with double-quotes per CSSOM spec

Attachments
Patch (3.50 KB, patch) 2018-04-24 14:11 PDT, Chris Nardi	no flags	Details Formatted Diff Diff
Patch (155.46 KB, patch) 2018-04-24 16:11 PDT, Chris Nardi	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-sierra (2.68 MB, application/zip) 2018-04-24 17:04 PDT, EWS Watchlist	no flags	Details
Update tests (211.62 KB, patch) 2018-04-24 18:18 PDT, Chris Nardi	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-sierra (2.45 MB, application/zip) 2018-04-24 19:23 PDT, EWS Watchlist	no flags	Details
Patch (284.63 KB, patch) 2018-04-24 19:50 PDT, Chris Nardi	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-sierra (2.28 MB, application/zip) 2018-04-24 20:55 PDT, EWS Watchlist	no flags	Details
Update additional tests (287.22 KB, patch) 2018-04-25 05:41 PDT, Chris Nardi	no flags	Details Formatted Diff Diff
Additional test fixes (288.13 KB, patch) 2018-04-25 06:37 PDT, Chris Nardi	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews200 for win-future (12.68 MB, application/zip) 2018-04-25 10:39 PDT, EWS Watchlist	no flags	Details
Update Win expectation (288.84 KB, patch) 2018-04-25 10:50 PDT, Chris Nardi	no flags	Details Formatted Diff Diff
Try rebasing (289.00 KB, patch) 2018-04-27 04:43 PDT, Chris Nardi	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Chris Nardi

Comment 1 2018-04-24 14:11:25 PDT

Created attachment 338669 [details] Patch

Chris Nardi

Comment 2 2018-04-24 16:11:36 PDT

Created attachment 338683 [details] Patch

EWS Watchlist

Comment 3 2018-04-24 17:04:55 PDT

Comment on attachment 338683 [details] Patch Attachment 338683 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7431512 New failing tests: imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property.html imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property.html fast/css/getComputedStyle/computed-style-cross-fade.html fast/events/mouse-cursor.html css3/filters/backdrop/backdropfilter-property-computed-style.html imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property.html fast/css/cursor-parsing.html css3/filters/filter-property-parsing.html fast/events/mouse-cursor-image-set.html css3/filters/unprefixed.html fast/css/url-with-multi-byte-unicode-escape.html fast/filter-image/parse-filter-image.html fast/shapes/parsing/parsing-shape-outside.html css3/filters/filter-property-computed-style.html fast/css/getComputedStyle/computed-style-border-image.html fast/css/image-set-setting.html imported/w3c/web-platform-tests/cssom/serialize-values.html fast/css/cursor-parsing-image-set.html fast/masking/parsing-clip-path-iri.html svg/css/svg-attribute-parser-mode.html css3/filters/backdrop/backdropfilter-property-parsing.html fast/css/image-set-parsing.html fast/css/uri-token-parsing.html svg/custom/marker-getPropertyValue.svg fast/events/mouse-cursor-multiframecur.html fast/backgrounds/multiple-backgrounds-computed-style.html

EWS Watchlist

Comment 4 2018-04-24 17:04:56 PDT

Created attachment 338687 [details] Archive of layout-test-results from ews101 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6

Chris Nardi

Comment 5 2018-04-24 18:18:57 PDT

Created attachment 338694 [details] Update tests

EWS Watchlist

Comment 6 2018-04-24 19:23:03 PDT

Comment on attachment 338694 [details] Update tests Attachment 338694 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7434870 New failing tests: fast/events/mouse-cursor-image-set.html imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property.html fast/css/image-set-parsing.html fast/css/url-with-multi-byte-unicode-escape.html imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property.html fast/css/cursor-parsing-image-set.html fast/css/getComputedStyle/computed-style-cross-fade.html fast/events/mouse-cursor-multiframecur.html fast/events/mouse-cursor.html css3/filters/filter-property-parsing.html imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property.html fast/css/cursor-parsing.html fast/css/image-set-setting.html fast/backgrounds/multiple-backgrounds-computed-style.html

EWS Watchlist

Comment 7 2018-04-24 19:23:04 PDT

Created attachment 338696 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6

Chris Nardi

Comment 8 2018-04-24 19:50:52 PDT

Created attachment 338698 [details] Patch

EWS Watchlist

Comment 9 2018-04-24 20:55:06 PDT

Comment on attachment 338698 [details] Patch Attachment 338698 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7436888 New failing tests: fast/css/image-set-parsing.html fast/css/cursor-parsing-image-set.html imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property.html fast/css/image-set-setting.html fast/css/cursor-parsing.html

EWS Watchlist

Comment 10 2018-04-24 20:55:07 PDT

Created attachment 338702 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6

Chris Nardi

Comment 11 2018-04-25 05:41:02 PDT

Created attachment 338722 [details] Update additional tests

Chris Nardi

Comment 12 2018-04-25 06:37:40 PDT

Created attachment 338724 [details] Additional test fixes

EWS Watchlist

Comment 13 2018-04-25 10:39:15 PDT

Comment on attachment 338724 [details] Additional test fixes Attachment 338724 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7452315 New failing tests: fast/css/parse-border-image-repeat-null-crash.html

EWS Watchlist

Comment 14 2018-04-25 10:39:27 PDT

Created attachment 338751 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Chris Nardi

Comment 15 2018-04-25 10:50:34 PDT

Created attachment 338754 [details] Update Win expectation

Antti Koivisto

Comment 16 2018-04-27 03:37:21 PDT

r=me

WebKit Commit Bot

Comment 17 2018-04-27 04:01:51 PDT

Comment on attachment 338754 [details] Update Win expectation Rejecting attachment 338754 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 338754, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: .txt patching file LayoutTests/resources/image-preload-helper.js patching file LayoutTests/svg/css/svg-attribute-parser-mode-expected.txt patching file LayoutTests/svg/css/svg-attribute-parser-mode.html patching file LayoutTests/svg/custom/marker-getPropertyValue-expected.txt patching file LayoutTests/svg/custom/marker-getPropertyValue.svg Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/7478842

Chris Nardi

Comment 18 2018-04-27 04:13:00 PDT

(In reply to WebKit Commit Bot from comment #17) > Comment on attachment 338754 [details] > Update Win expectation > > Rejecting attachment 338754 [details] from commit-queue. > > Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', > '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', > 'apply-attachment', '--no-update', '--non-interactive', 338754, > '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit > > Last 500 characters of output: > .txt > patching file LayoutTests/resources/image-preload-helper.js > patching file LayoutTests/svg/css/svg-attribute-parser-mode-expected.txt > patching file LayoutTests/svg/css/svg-attribute-parser-mode.html > patching file LayoutTests/svg/custom/marker-getPropertyValue-expected.txt > patching file LayoutTests/svg/custom/marker-getPropertyValue.svg > > Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', > '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: > /Volumes/Data/EWS/WebKit > > Full output: http://webkit-queues.webkit.org/results/7478842 The output doesn't seem to have any reason that the patch was rejected. My guess was some merge conflict, but it applies cleanly locally, so I'm not sure if this is a genuine problem or not.

Chris Nardi

Comment 19 2018-04-27 04:43:53 PDT

Created attachment 338982 [details] Try rebasing

Chris Nardi

Comment 20 2018-04-30 13:06:19 PDT

The new patch should (hopefully) cleanly apply now.

Chris Nardi

Comment 21 2018-05-03 19:21:19 PDT

Antti: maybe we can try this again? I'm hoping to avoid another situation where the patch no longer applies.

WebKit Commit Bot

Comment 22 2018-05-04 10:32:55 PDT

Comment on attachment 338982 [details] Try rebasing Clearing flags on attachment: 338982 Committed r231359: <https://trac.webkit.org/changeset/231359>

WebKit Commit Bot

Comment 23 2018-05-04 10:32:57 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 24 2018-05-04 10:34:14 PDT

<rdar://problem/39980859>

Note You need to log in before you can comment on or make changes to this bug.