Bug 184910

Summary:

Adjust XMLHttpRequest username/password precedence rules

Product:

WebKit

Reporter:

Anne van Kesteren <annevk>

Component:

DOM

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, ews-feeder, ews-watchlist, fred.wang, rbuis, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Archive of layout-test-results from ews100 for mac-sierra	none
Archive of layout-test-results from ews204 for win-future	none
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Archive of layout-test-results from ews113 for mac-sierra	none
Patch	none
Archive of layout-test-results from ews103 for mac-sierra	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Archive of layout-test-results from ews112 for mac-sierra	none
Patch	none
Patch	none

Anne van Kesteren

Reported 2018-04-24 02:26:59 PDT

See https://github.com/w3c/web-platform-tests/pull/10419.

Attachments
Patch (7.96 KB, patch) 2018-09-02 08:13 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (898.91 KB, application/zip) 2018-09-02 09:07 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews100 for mac-sierra (2.31 MB, application/zip) 2018-09-02 09:16 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews204 for win-future (12.82 MB, application/zip) 2018-09-02 09:47 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (13.19 MB, application/zip) 2018-09-02 09:48 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews113 for mac-sierra (3.03 MB, application/zip) 2018-09-02 09:49 PDT, EWS Watchlist	no flags	Details
Patch (5.86 KB, patch) 2018-09-02 10:52 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-sierra (2.30 MB, application/zip) 2018-09-02 11:57 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.83 MB, application/zip) 2018-09-02 12:07 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews112 for mac-sierra (3.02 MB, application/zip) 2018-09-02 12:34 PDT, EWS Watchlist	no flags	Details
Patch (6.74 KB, patch) 2018-09-02 12:42 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (6.73 KB, patch) 2018-09-04 13:00 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Rob Buis

Comment 1 2018-09-02 08:13:04 PDT

Created attachment 348730 [details] Patch

EWS Watchlist

Comment 2 2018-09-02 09:07:21 PDT

Comment on attachment 348730 [details] Patch Attachment 348730 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9070546 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 3 2018-09-02 09:07:23 PDT

Created attachment 348731 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 4 2018-09-02 09:16:56 PDT

Comment on attachment 348730 [details] Patch Attachment 348730 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9070578 New failing tests: imported/w3c/web-platform-tests/xhr/send-authentication-competing-names-passwords.htm http/tests/xmlhttprequest/basic-auth.html

EWS Watchlist

Comment 5 2018-09-02 09:16:58 PDT

Created attachment 348732 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 6 2018-09-02 09:47:41 PDT

Comment on attachment 348730 [details] Patch Attachment 348730 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/9070690 New failing tests: http/tests/xmlhttprequest/basic-auth.html

EWS Watchlist

Comment 7 2018-09-02 09:47:52 PDT

Created attachment 348735 [details] Archive of layout-test-results from ews204 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

EWS Watchlist

Comment 8 2018-09-02 09:48:40 PDT

Comment on attachment 348730 [details] Patch Attachment 348730 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9070600 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 9 2018-09-02 09:48:44 PDT

Created attachment 348736 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

EWS Watchlist

Comment 10 2018-09-02 09:49:19 PDT

Comment on attachment 348730 [details] Patch Attachment 348730 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9070639 New failing tests: imported/w3c/web-platform-tests/xhr/send-authentication-competing-names-passwords.htm http/tests/xmlhttprequest/basic-auth.html

EWS Watchlist

Comment 11 2018-09-02 09:49:21 PDT

Created attachment 348737 [details] Archive of layout-test-results from ews113 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-sierra Platform: Mac OS X 10.12.6

Rob Buis

Comment 12 2018-09-02 10:52:55 PDT

Created attachment 348739 [details] Patch

EWS Watchlist

Comment 13 2018-09-02 11:57:36 PDT

Comment on attachment 348739 [details] Patch Attachment 348739 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9071576 New failing tests: imported/w3c/web-platform-tests/xhr/send-authentication-competing-names-passwords.htm http/tests/xmlhttprequest/basic-auth.html

EWS Watchlist

Comment 14 2018-09-02 11:57:38 PDT

Created attachment 348742 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 15 2018-09-02 12:07:52 PDT

Comment on attachment 348739 [details] Patch Attachment 348739 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9071587 New failing tests: imported/w3c/web-platform-tests/xhr/send-authentication-competing-names-passwords.htm http/tests/xmlhttprequest/basic-auth.html

EWS Watchlist

Comment 16 2018-09-02 12:07:54 PDT

Created attachment 348744 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 17 2018-09-02 12:34:04 PDT

Comment on attachment 348739 [details] Patch Attachment 348739 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9071628 New failing tests: imported/w3c/web-platform-tests/xhr/send-authentication-competing-names-passwords.htm http/tests/xmlhttprequest/basic-auth.html

EWS Watchlist

Comment 18 2018-09-02 12:34:06 PDT

Created attachment 348747 [details] Archive of layout-test-results from ews112 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-sierra Platform: Mac OS X 10.12.6

Rob Buis

Comment 19 2018-09-02 12:42:46 PDT

Created attachment 348748 [details] Patch

Frédéric Wang (:fredw)

Comment 20 2018-09-04 01:00:42 PDT

Comment on attachment 348748 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348748&action=review > Source/WebCore/ChangeLog:8 > + Step 9.1 and 9.2 in the XMLHTTPRequest::open [1] algorithm Steps

Rob Buis

Comment 21 2018-09-04 13:00:44 PDT

Created attachment 348842 [details] Patch

EWS

Comment 22 2018-09-04 13:01:58 PDT

Comment on attachment 348842 [details] Patch Rejecting attachment 348842 [details] from commit-queue. rbuis@igalia.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.

WebKit Commit Bot

Comment 23 2018-09-04 13:37:37 PDT

Comment on attachment 348842 [details] Patch Clearing flags on attachment: 348842 Committed r235631: <https://trac.webkit.org/changeset/235631>

WebKit Commit Bot

Comment 24 2018-09-04 13:37:39 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 25 2018-09-04 13:38:28 PDT

<rdar://problem/44110472>

Note You need to log in before you can comment on or make changes to this bug.