Web Inspector: Annotate Same-Site cookies

• Component: Web Inspector
• Status: RESOLVED FIXED

[Daniel Bates]

We should annotate Same-Site cookies in the Web Inspector. In particular, we should annotate the Same-Site policy (strict or lax) for each cookie.

[BJ Burg]

<rdar://problem/35178209>

[Daniel Bates]

Created attachment 341307 [details]
[Patch] Work-in-progress

[Daniel Bates]

Created attachment 341309 [details]
[Patch] Work-in-progress

Rebased patch following the landing of the patch for bug #185041.

[EWS Watchlist]

Attachment 341309 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/cocoa/CookieCocoa.mm:129:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Joseph Pecoraro]

Comment on attachment 341309 [details]
[Patch] Work-in-progress

View in context: https://bugs.webkit.org/attachment.cgi?id=341309&action=review

Nice, the patch looks good to me.

> Source/WebInspectorUI/UserInterface/Models/Cookie.js:114
> +            console.error("Invalid SameSite type", sameSiteType);

Might as well return something here just in case. Probably `return sameSiteType`.

> Source/WebInspectorUI/UserInterface/Views/ResourceCookiesContentView.js:93
> +            cell.textContent = cookie.sameSite == WI.Cookie.SameSiteType.None ? emDash : WI.Cookie.displayNameForSameSiteType(cookie.sameSite);

Style: ===

[Daniel Bates]

Created attachment 341326 [details]
Patch and layout test

[EWS Watchlist]

Attachment 341326 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/cocoa/CookieCocoa.mm:133:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Daniel Bates]

(In reply to Joseph Pecoraro from comment #5)
> > Source/WebInspectorUI/UserInterface/Models/Cookie.js:114
> > +            console.error("Invalid SameSite type", sameSiteType);
> 
> Might as well return something here just in case. Probably `return
> sameSiteType`.
> 

Fixed.

> > Source/WebInspectorUI/UserInterface/Views/ResourceCookiesContentView.js:93
> > +            cell.textContent = cookie.sameSite == WI.Cookie.SameSiteType.None ? emDash : WI.Cookie.displayNameForSameSiteType(cookie.sameSite);
> 
> Style: ===

Fixed.

[BJ Burg]

Comment on attachment 341326 [details]
Patch and layout test

View in context: https://bugs.webkit.org/attachment.cgi?id=341326&action=review

r=me, great patch. Let's wait for EWS, I anticipate nitpicking platform-specific results.

> Source/WebCore/platform/Cookie.h:171
> +    using values = EnumValues<

This is cool.

> Source/WebCore/platform/network/cocoa/CookieCocoa.mm:39
> +static NSString * const NSHTTPCookieSameSiteStrict = @"strict";

This stuff should be in NSHTTPCookieSPI, but that file doesn't exist yet.

> LayoutTests/http/tests/inspector/network/har/har-page-expected.txt:718
> +              "sameSite": "Lax"

I believe we may need different expectations per port, if this isn't going to be propagated. Let's see what EWS says.

[EWS Watchlist]

Comment on attachment 341326 [details]
Patch and layout test

Attachment 341326 [details] did not pass jsc-ews (mac):
Output: http://webkit-queues.webkit.org/results/7804230

New failing tests:
stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-eager-no-cjit

[Daniel Bates]

(In reply to Build Bot from comment #10)
> Comment on attachment 341326 [details]
> Patch and layout test
> 
> Attachment 341326 [details] did not pass jsc-ews (mac):
> Output: http://webkit-queues.webkit.org/results/7804230
> 
> New failing tests:
> stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-eager-no-
> cjit

I am unclear how a Web Inspector change could cause this test failure.

[Daniel Bates]

Comment on attachment 341326 [details]
Patch and layout test

Clearing flags on attachment: 341326

Committed r232318: <https://trac.webkit.org/changeset/232318>

[Daniel Bates]

All reviewed patches have been landed.  Closing bug.