Bug 18489 – Squirrelfish doesn't build on linux

• Component: Platform
• Status: RESOLVED INVALID

[Gabor Loki]

Currently the squirrelfish branch is not compiled on linux.

The first error looks like:
g++ -c -pipe -Wreturn-type ...
-o tmp/JSBase.o ../../../JavaScriptCore/API/JSBase.cpp
In file included from ../../../JavaScriptCore/kjs/JSGlobalObject.h:26,
                 from ../../../JavaScriptCore/API/JSBase.cpp:32:
../../../JavaScriptCore/kjs/JSVariableObject.h:32:22: error: Register.h: No such
file or directory
... 

Which means there are missing Makefile rules, include headers, etc.

So, I have created a small patch which solves this problem.
At least in my system there are no more build failure.

[Gabor Loki]

Created attachment 20531 [details]
Proposed Squirrelfish build fix for Linux

Let me know if I have missed something.

[Geoffrey Garen]

Comment on attachment 20531 [details]
Proposed Squirrelfish build fix for Linux

Committed revision 31883.

I had to remove tab characters from the ChangeLog. In the future, please use spaces, rather than tabs.

[Gabor Loki]

Created attachment 20886 [details]
Build, template, macros fixes for Linux

This patch is for revision 32670.

The proposed fix contains the followings:
- rename JavaScriptCore/kjs/LocalStorage.h to JavaScriptCore/kjs/LocalStorageEntry.h (like in http://trac.webkit.org/changeset/32259), but I didn't able to update XCode Project file. Please someone (who have a Mac) update this.

- template problem in JavaScriptCore/kjs/collector.{h,cpp}: A new template instance (like in 'allocateNumber') cannot be created only from forward declaration.

- add missing QT_*_NAMESPACE defines (like in http://trac.webkit.org/changeset/32306).

- add some missing includes and sources

[Gabor Loki]

Revision 32670 is not build on Linux (Qt).

I have attached a proposed patch, see my last comment.

[Maciej Stachowiak]

Comment on attachment 20886 [details]
Build, template, macros fixes for Linux

These fixes look good to me.

[Gabor Loki]

Created attachment 21157 [details]
Add missing includes and sources

Revision 33436 is not build on Linux (Qt).

The proposed fix contains the followings:
- Add missing includes
- Remove extra qualification
- Add missing sources to WebCore.pro

[Jan Alonzo]

Hi Gabor

The squirrelfish branch has just been merged into WebKit trunk today. I'm not sure if this patch still applies (gtk port in linux builds fine for example).

Regards

[Gabor Loki]

The squirrelfish branch have been merged.
Qt port is also OK (rev 34071).

[Alexey Proskuryakov]

Comment on attachment 21157 [details]
Add missing includes and sources

Clearing the review flag, so that this doesn't show up in review queue.