Summary: | Squirrelfish doesn't build on linux | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gabor Loki <loki> | ||||||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED INVALID | ||||||||||
Severity: | Blocker | CC: | jmalonzo | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | Linux | ||||||||||
Attachments: |
|
Description
Gabor Loki
2008-04-14 07:18:58 PDT
Created attachment 20531 [details]
Proposed Squirrelfish build fix for Linux
Let me know if I have missed something.
Comment on attachment 20531 [details]
Proposed Squirrelfish build fix for Linux
Committed revision 31883.
I had to remove tab characters from the ChangeLog. In the future, please use spaces, rather than tabs.
Created attachment 20886 [details] Build, template, macros fixes for Linux This patch is for revision 32670. The proposed fix contains the followings: - rename JavaScriptCore/kjs/LocalStorage.h to JavaScriptCore/kjs/LocalStorageEntry.h (like in http://trac.webkit.org/changeset/32259), but I didn't able to update XCode Project file. Please someone (who have a Mac) update this. - template problem in JavaScriptCore/kjs/collector.{h,cpp}: A new template instance (like in 'allocateNumber') cannot be created only from forward declaration. - add missing QT_*_NAMESPACE defines (like in http://trac.webkit.org/changeset/32306). - add some missing includes and sources Revision 32670 is not build on Linux (Qt). I have attached a proposed patch, see my last comment. Comment on attachment 20886 [details]
Build, template, macros fixes for Linux
These fixes look good to me.
Created attachment 21157 [details]
Add missing includes and sources
Revision 33436 is not build on Linux (Qt).
The proposed fix contains the followings:
- Add missing includes
- Remove extra qualification
- Add missing sources to WebCore.pro
Hi Gabor The squirrelfish branch has just been merged into WebKit trunk today. I'm not sure if this patch still applies (gtk port in linux builds fine for example). Regards The squirrelfish branch have been merged. Qt port is also OK (rev 34071). Comment on attachment 21157 [details]
Add missing includes and sources
Clearing the review flag, so that this doesn't show up in review queue.
|