Bug 184864

Summary:

Expose whether you've built with the Apple Internal SDK

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

New Bugs

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, mitz, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	wenson_hsieh: review+

Description Dean Jackson 2018-04-21 13:00:11 PDT

Expose whether you've build with the Apple Internal SDK

Comment 1 Dean Jackson 2018-04-21 13:02:01 PDT

Created attachment 338532 [details]
Patch

Comment 2 Dean Jackson 2018-04-21 13:06:32 PDT

Created attachment 338534 [details]
Patch

Comment 3 Wenson Hsieh 2018-04-21 13:27:14 PDT

Comment on attachment 338534 [details]
Patch

I suppose this would be for a test that we want to run (and pass) on OpenSource bots, but may exercise different codepaths if we've built WebKit with an internal SDK? This seems a bit similar to certain iOS layout tests that we skip in OpenSource TestExpectations but mark as Pass in Internal...I wonder if it makes more sense to just skip these tests in OpenSource instead.

Comment 4 Dean Jackson 2018-04-21 13:29:00 PDT

Committed r230892: <https://trac.webkit.org/changeset/230892>

Comment 5 Radar WebKit Bug Importer 2018-04-21 13:29:18 PDT

<rdar://problem/39623401>

Comment 6 Alexey Proskuryakov 2018-04-22 17:27:02 PDT

> I wonder if it makes more sense to just skip these tests in OpenSource instead.

+1