Bug 184853

Summary:

Make DocumentThreadableLoader error logging more consistent

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

Page Loading

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, beidson, cdumez, commit-queue, dbates, ews-watchlist, japhet, rniwa, webkit-bug-importer, wilander

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch for landing	none

youenn fablet

Reported 2018-04-20 17:15:54 PDT

This will allow logging to be more consistent between WK1 and WK2

Attachments
Patch (3.32 KB, patch) 2018-04-20 17:18 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.21 MB, application/zip) 2018-04-20 20:53 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.83 MB, application/zip) 2018-04-20 22:21 PDT, EWS Watchlist	no flags	Details
Patch (190.23 KB, patch) 2018-04-23 15:04 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (253.47 KB, patch) 2018-04-23 20:16 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (253.30 KB, patch) 2018-04-23 20:59 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (253.28 KB, patch) 2018-04-23 23:10 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (251.56 KB, patch) 2018-04-24 08:36 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch for landing (266.98 KB, patch) 2018-04-25 10:18 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2018-04-20 17:18:16 PDT

Created attachment 338500 [details] Patch

EWS Watchlist

Comment 2 2018-04-20 20:53:34 PDT

Comment on attachment 338500 [details] Patch Attachment 338500 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7392434 New failing tests: imported/w3c/web-platform-tests/service-workers/service-worker/opaque-response-preloaded.https.html imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-redirect.https.html imported/w3c/web-platform-tests/service-workers/service-worker/redirected-response.https.html

EWS Watchlist

Comment 3 2018-04-20 20:53:36 PDT

Created attachment 338516 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

EWS Watchlist

Comment 4 2018-04-20 22:21:52 PDT

Comment on attachment 338500 [details] Patch Attachment 338500 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7393470 New failing tests: imported/w3c/web-platform-tests/service-workers/service-worker/opaque-response-preloaded.https.html imported/w3c/web-platform-tests/service-workers/service-worker/redirected-response.https.html

EWS Watchlist

Comment 5 2018-04-20 22:21:53 PDT

Created attachment 338522 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

youenn fablet

Comment 6 2018-04-23 15:04:50 PDT

Created attachment 338604 [details] Patch

youenn fablet

Comment 7 2018-04-23 20:16:18 PDT

Created attachment 338633 [details] Patch

youenn fablet

Comment 8 2018-04-23 20:59:34 PDT

Created attachment 338635 [details] Patch

youenn fablet

Comment 9 2018-04-23 23:10:01 PDT

Created attachment 338639 [details] Patch

youenn fablet

Comment 10 2018-04-24 08:36:40 PDT

Created attachment 338652 [details] Patch

Chris Dumez

Comment 11 2018-04-25 08:54:25 PDT

Comment on attachment 338652 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338652&action=review > Source/WebCore/loader/CrossOriginPreflightChecker.cpp:63 > + Frame* frame = loader.document().frame(); auto* > Source/WebCore/loader/CrossOriginPreflightChecker.cpp:68 > + if (frame->document()) if (auto* document = frame->document()) document->

youenn fablet

Comment 12 2018-04-25 10:18:17 PDT

Created attachment 338749 [details] Patch for landing

WebKit Commit Bot

Comment 13 2018-04-25 10:58:04 PDT

Comment on attachment 338749 [details] Patch for landing Clearing flags on attachment: 338749 Committed r231000: <https://trac.webkit.org/changeset/231000>

WebKit Commit Bot

Comment 14 2018-04-25 10:58:06 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 15 2018-04-25 10:59:31 PDT

<rdar://problem/39727000>

Note You need to log in before you can comment on or make changes to this bug.