Bug 18485

Summary: Typo and documentation fix for build-webkit
Product: WebKit Reporter: Jan Alonzo <jmalonzo>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: jchaffraix
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Typo and doc fixes mjs: review+

Jan Alonzo
Reported 2008-04-14 04:06:11 PDT
build-webkit currently has a typo in foreign object and the documentation for --clean is unclear. Also, the doc for --video currently doesn't show if it's enabled or not.
Attachments
Typo and doc fixes (2.52 KB, patch)
2008-04-14 04:08 PDT, Jan Alonzo 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jan Alonzo
Comment 1 2008-04-14 04:08:15 PDT
Created attachment 20527 [details] Typo and doc fixes This patch fixes the typo and FO and --clean doc of build-webkit.
Julien Chaffraix
Comment 2 2008-04-14 05:14:32 PDT
> This patch fixes the typo and FO and --clean doc of build-webkit. > The fix for the default video option is weird. The real issue is that we do not have a platform check in isCygwin() and thus returns an empty string when we are not under cygwin. I would advise you to make isCygwin() behave as the isOSX() method: check for platforms and add a fallback.
Maciej Stachowiak
Comment 3 2008-04-22 22:35:34 PDT
Comment on attachment 20527 [details] Typo and doc fixes r=me
Mark Rowe (bdash)
Comment 4 2008-04-24 17:53:35 PDT
Landed in r32527.
Note You need to log in before you can comment on or make changes to this bug.