Bug 18485

Summary: Typo and documentation fix for build-webkit
Product: WebKit Reporter: Jan Alonzo <jmalonzo@gmail.com>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned@lists.webkit.org>
Status: RESOLVED FIXED    
Severity: Normal CC: jchaffraix@webkit.org
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Typo and doc fixes mjs: review+

Description From 2008-04-14 04:06:11 PST
build-webkit currently has a typo in foreign object and the documentation for --clean is unclear. Also, the doc for --video currently doesn't show if it's enabled or not.
------- Comment #1 From 2008-04-14 04:08:15 PST -------
Created an attachment (id=20527) [details]
Typo and doc fixes

This patch fixes the typo and FO and --clean doc of build-webkit.
------- Comment #2 From 2008-04-14 05:14:32 PST -------
> This patch fixes the typo and FO and --clean doc of build-webkit.
> 

The fix for the default video option is weird.
The real issue is that we do not have a platform check in isCygwin() and thus returns an empty string when we are not under cygwin.

I would advise you to make isCygwin() behave as the isOSX() method: check for platforms and add a fallback.
------- Comment #3 From 2008-04-22 22:35:34 PST -------
(From update of attachment 20527 [details])
r=me
------- Comment #4 From 2008-04-24 17:53:35 PST -------
Landed in r32527.