Bug 18485 - Typo and documentation fix for build-webkit
Summary: Typo and documentation fix for build-webkit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-14 04:06 PDT by Jan Alonzo
Modified: 2008-04-24 17:53 PDT (History)
1 user (show)

See Also:


Attachments
Typo and doc fixes (2.52 KB, patch)
2008-04-14 04:08 PDT, Jan Alonzo
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Alonzo 2008-04-14 04:06:11 PDT
build-webkit currently has a typo in foreign object and the documentation for --clean is unclear. Also, the doc for --video currently doesn't show if it's enabled or not.
Comment 1 Jan Alonzo 2008-04-14 04:08:15 PDT
Created attachment 20527 [details]
Typo and doc fixes

This patch fixes the typo and FO and --clean doc of build-webkit.
Comment 2 Julien Chaffraix 2008-04-14 05:14:32 PDT
> This patch fixes the typo and FO and --clean doc of build-webkit.
> 

The fix for the default video option is weird.
The real issue is that we do not have a platform check in isCygwin() and thus returns an empty string when we are not under cygwin.

I would advise you to make isCygwin() behave as the isOSX() method: check for platforms and add a fallback.
Comment 3 Maciej Stachowiak 2008-04-22 22:35:34 PDT
Comment on attachment 20527 [details]
Typo and doc fixes

r=me
Comment 4 Mark Rowe (bdash) 2008-04-24 17:53:35 PDT
Landed in r32527.