Bug 184835

Summary: Mandate H264 hardware encoder for Mac in libwebrtc
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, eric.carlson, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 184855    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing
none
Patch none

youenn fablet
Reported 2018-04-20 13:36:31 PDT
Mandate H264 hardware encoder for Mac in libwebrtc
Attachments
Patch (12.60 KB, patch)
2018-04-20 13:49 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (13.02 KB, patch)
2018-04-20 14:16 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (13.01 KB, patch)
2018-04-20 15:28 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (13.01 KB, patch)
2018-04-20 15:29 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (16.93 KB, patch)
2018-04-30 11:27 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2018-04-20 13:49:18 PDT
Created attachment 338458 [details] Patch
youenn fablet
Comment 2 2018-04-20 14:16:31 PDT
Created attachment 338459 [details] Patch
Eric Carlson
Comment 3 2018-04-20 15:11:44 PDT
Comment on attachment 338459 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338459&action=review > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm:615 > + CFTypeRef sessionValues[] = { webrtc::isH264HardwareEncoderAllowed() ? kCFBooleanTrue : kCFBooleanFalse, webrtc::isH264HardwareEncoderAllowed() ? kCFBooleanTrue : kCFBooleanFalse, kCFBooleanTrue }; Nit: it seems slightly wasteful to call webrtc::isH264HardwareEncoderAllowed() twice here.
youenn fablet
Comment 4 2018-04-20 15:28:54 PDT
Created attachment 338468 [details] Patch for landing
youenn fablet
Comment 5 2018-04-20 15:29:39 PDT
Created attachment 338469 [details] Patch for landing
youenn fablet
Comment 6 2018-04-20 15:30:46 PDT
(In reply to Eric Carlson from comment #3) > Comment on attachment 338459 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=338459&action=review > > > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm:615 > > + CFTypeRef sessionValues[] = { webrtc::isH264HardwareEncoderAllowed() ? kCFBooleanTrue : kCFBooleanFalse, webrtc::isH264HardwareEncoderAllowed() ? kCFBooleanTrue : kCFBooleanFalse, kCFBooleanTrue }; > > Nit: it seems slightly wasteful to call > webrtc::isH264HardwareEncoderAllowed() twice here. Thanks for the review. I updated the patch accordingly.
WebKit Commit Bot
Comment 7 2018-04-20 15:57:59 PDT
Comment on attachment 338469 [details] Patch for landing Clearing flags on attachment: 338469 Committed r230862: <https://trac.webkit.org/changeset/230862>
WebKit Commit Bot
Comment 8 2018-04-20 15:58:01 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-04-20 15:58:18 PDT
<rdar://problem/39612500>
WebKit Commit Bot
Comment 10 2018-04-20 18:23:15 PDT
Re-opened since this is blocked by bug 184855
youenn fablet
Comment 11 2018-04-30 11:27:28 PDT
Created attachment 339131 [details] Patch
youenn fablet
Comment 12 2018-04-30 13:00:35 PDT
Timeouts were due to too many hw encoders allocated and returning too early to use sw encoders
WebKit Commit Bot
Comment 13 2018-04-30 13:28:27 PDT
Comment on attachment 339131 [details] Patch Clearing flags on attachment: 339131 Committed r231167: <https://trac.webkit.org/changeset/231167>
WebKit Commit Bot
Comment 14 2018-04-30 13:28:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.