Bug 184834

Summary: Layout Test accessibility/mac/async-increment-decrement-action.html is flaky
Product: WebKit Reporter: Nan Wang <n_wang>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=184742
Attachments:
Description Flags
patch
none
patch cfleizach: review+

Description Nan Wang 2018-04-20 12:09:49 PDT 
The following layout test is flaky on macOS Debug

accessibility/mac/async-increment-decrement-action.html

Probable cause:

[insert probable cause]

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=accessibility%2Fmac%2Fasync-increment-decrement-action.html
Comment 1 Radar WebKit Bug Importer 2018-04-20 12:10:06 PDT 
<rdar://problem/39604753>
Comment 2 Nan Wang 2018-04-20 12:14:58 PDT 
Created attachment 338451 [details]
patch

fix the test
Comment 3 chris fleizach 2018-04-20 12:19:08 PDT 
Comment on attachment 338451 [details]
patch

this seems a bit flaky. is there a better way?
Comment 4 Nan Wang 2018-04-20 12:22:54 PDT 
(In reply to chris fleizach from comment #3)
> Comment on attachment 338451 [details]
> patch
> 
> this seems a bit flaky. is there a better way?

Not easy way since there's no callback from the actions. Or we can just test that these actions are async now and return early with the non changed result without timing out.
Comment 5 chris fleizach 2018-04-20 12:27:49 PDT 
(In reply to Nan Wang from comment #4)
> (In reply to chris fleizach from comment #3)
> > Comment on attachment 338451 [details]
> > patch
> > 
> > this seems a bit flaky. is there a better way?
> 
> Not easy way since there's no callback from the actions. Or we can just test
> that these actions are async now and return early with the non changed
> result without timing out.

that seems reasonable
Comment 6 Nan Wang 2018-04-20 12:42:17 PDT 
Created attachment 338452 [details]
patch

updated the test
Comment 7 chris fleizach 2018-04-20 12:44:21 PDT 
Comment on attachment 338452 [details]
patch

looks ok, just add a comment why value isn't changing and how that verifies it's async
Comment 8 Nan Wang 2018-04-20 12:45:39 PDT 
(In reply to chris fleizach from comment #7)
> Comment on attachment 338452 [details]
> patch
> 
> looks ok, just add a comment why value isn't changing and how that verifies
> it's async

Ok will do after all the tests are passed
Comment 9 Nan Wang 2018-04-20 14:02:57 PDT 
Committed r230855: <https://trac.webkit.org/changeset/230855>