Bug 184831

Summary: Pausing should clear m_waitingToEnterFullscreen
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Eric Carlson
Reported 2018-04-20 11:20:48 PDT
pause() should clear m_waitingToEnterFullscreen so a subsequent play() will go into fullscreen.
Attachments
Patch (1.27 KB, patch)
2018-04-20 11:33 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-04-20 11:21:26 PDT
<rdar://problem/39602852>
Eric Carlson
Comment 2 2018-04-20 11:33:40 PDT
Created attachment 338443 [details] Patch
WebKit Commit Bot
Comment 3 2018-04-20 12:01:58 PDT
Comment on attachment 338443 [details] Patch Clearing flags on attachment: 338443 Committed r230846: <https://trac.webkit.org/changeset/230846>
WebKit Commit Bot
Comment 4 2018-04-20 12:01:59 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 5 2018-04-30 09:55:27 PDT
Comment on attachment 338443 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338443&action=review > Source/WebCore/html/HTMLMediaElement.cpp:3526 > + if (m_waitingToEnterFullscreen) > + m_waitingToEnterFullscreen = false; The if statement here isn’t needed. We don’t need to check a boolean to see if it’s true before setting it false.
Note You need to log in before you can comment on or make changes to this bug.