Bug 184826

Summary: Element fullscreen, expose WKWebView _fullScreenPlaceholderView as iOS SPI
Product: WebKit Reporter: Jeremy Jones <jeremyj-wk>
Component: WebKit2Assignee: Jeremy Jones <jeremyj-wk>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: iPhone / iPad   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jeremy Jones
Reported 2018-04-20 10:30:37 PDT
Element fullscreen, expose WKWebView _fullScreenPlaceholderView as iOS SPI
Attachments
Patch (5.43 KB, patch)
2018-04-20 10:36 PDT, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jeremy Jones
Comment 1 2018-04-20 10:31:58 PDT
rdar://problem/39600825
Jeremy Jones
Comment 2 2018-04-20 10:36:35 PDT
Created attachment 338437 [details] Patch
Tim Horton
Comment 3 2018-04-20 14:59:53 PDT
Comment on attachment 338437 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338437&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:410 > +- (UIView *)_fullScreenPlaceholderView WK_API_AVAILABLE(ios(WK_IOS_TBA)); What about Mac? (and then, is this in the wrong place?)
Jeremy Jones
Comment 4 2018-04-20 15:03:18 PDT
(In reply to Tim Horton from comment #3) > Comment on attachment 338437 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=338437&action=review > > > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:410 > > +- (UIView *)_fullScreenPlaceholderView WK_API_AVAILABLE(ios(WK_IOS_TBA)); > > What about Mac? (and then, is this in the wrong place?) Already exists for Mac with a different return type.
Tim Horton
Comment 5 2018-04-20 15:10:48 PDT
(In reply to Jeremy Jones from comment #4) > (In reply to Tim Horton from comment #3) > > Comment on attachment 338437 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=338437&action=review > > > > > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:410 > > > +- (UIView *)_fullScreenPlaceholderView WK_API_AVAILABLE(ios(WK_IOS_TBA)); > > > > What about Mac? (and then, is this in the wrong place?) > > Already exists for Mac with a different return type. Ah!
WebKit Commit Bot
Comment 6 2018-04-20 17:09:33 PDT
Comment on attachment 338437 [details] Patch Clearing flags on attachment: 338437 Committed r230868: <https://trac.webkit.org/changeset/230868>
WebKit Commit Bot
Comment 7 2018-04-20 17:09:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.