Bug 184826 – Element fullscreen, expose WKWebView _fullScreenPlaceholderView as iOS SPI

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Jeremy Jones]

Element fullscreen, expose WKWebView _fullScreenPlaceholderView as iOS SPI

[Jeremy Jones]

rdar://problem/39600825

[Jeremy Jones]

Created attachment 338437 [details]
Patch

[Tim Horton]

Comment on attachment 338437 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338437&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:410
> +- (UIView *)_fullScreenPlaceholderView WK_API_AVAILABLE(ios(WK_IOS_TBA));

What about Mac? (and then, is this in the wrong place?)

[Jeremy Jones]

(In reply to Tim Horton from comment #3)
> Comment on attachment 338437 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=338437&action=review
> 
> > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:410
> > +- (UIView *)_fullScreenPlaceholderView WK_API_AVAILABLE(ios(WK_IOS_TBA));
> 
> What about Mac? (and then, is this in the wrong place?)

Already exists for Mac with a different return type.

[Tim Horton]

(In reply to Jeremy Jones from comment #4)
> (In reply to Tim Horton from comment #3)
> > Comment on attachment 338437 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=338437&action=review
> > 
> > > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:410
> > > +- (UIView *)_fullScreenPlaceholderView WK_API_AVAILABLE(ios(WK_IOS_TBA));
> > 
> > What about Mac? (and then, is this in the wrong place?)
> 
> Already exists for Mac with a different return type.

Ah!

[WebKit Commit Bot]

Comment on attachment 338437 [details]
Patch

Clearing flags on attachment: 338437

Committed r230868: <https://trac.webkit.org/changeset/230868>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.