Bug 184825

Summary: [iOS] LayoutTest http/tests/quicklook/hide-referer-on-navigation.html is failing
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: Plug-insAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, sihui_liu, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Sihui Liu
Reported 2018-04-20 10:20:29 PDT
After making policy decisions asynchronous https://bugs.webkit.org/show_bug.cgi?id=180568, this test fails.
Attachments
Patch (4.24 KB, patch)
2018-04-20 10:32 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch (1.70 KB, patch)
2018-04-20 15:39 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2018-04-20 10:22:32 PDT
<rdar://problem/38924997>
Sihui Liu
Comment 2 2018-04-20 10:32:39 PDT
Created attachment 338435 [details] Patch
Geoffrey Garen
Comment 3 2018-04-20 15:00:36 PDT
Comment on attachment 338435 [details] Patch I think you've got the diagnosis right here. That's great! Let's re-use the "runAsync" flag to specify that we don't want UIHelper.wait() to end the test early, rather than adding the "shouldWait" flag. I think the flags philosophically mean the same thing -- with the exception that re-using "runAsync" requires hide-referer-on-navigation.html to call testRunner.waitUntilDone() itself before it calls runTest().
Sihui Liu
Comment 4 2018-04-20 15:39:00 PDT
Created attachment 338471 [details] Patch
Geoffrey Garen
Comment 5 2018-04-26 14:14:47 PDT
Comment on attachment 338471 [details] Patch r=me
WebKit Commit Bot
Comment 6 2018-04-26 14:41:44 PDT
Comment on attachment 338471 [details] Patch Clearing flags on attachment: 338471 Committed r231075: <https://trac.webkit.org/changeset/231075>
WebKit Commit Bot
Comment 7 2018-04-26 14:41:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.