Bug 184812

Summary:

Update Alignment shorthands to the spec now that they are not ambiguous

Product:

WebKit

Reporter:

Javier Fernandez <jfernandez>

Component:

CSS

Assignee:

Javier Fernandez <jfernandez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin, ews-watchlist, hyatt, jfernandez, koivisto, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugzilla.mozilla.org/show_bug.cgi?id=1339656
https://bugs.chromium.org/p/chromium/issues/detail?id=829806

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews106 for mac-sierra-wk2	none
Archive of layout-test-results from ews103 for mac-sierra	none
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Archive of layout-test-results from ews115 for mac-sierra	none
Patch	none
Patch	none

Javier Fernandez

Reported 2018-04-20 04:47:47 PDT

The grammar was simplified, and as a result the ambiguity is gone now. See: https://github.com/w3c/csswg-drafts/issues/2276#issuecomment-378757319

Attachments
Patch (83.42 KB, patch) 2018-04-20 04:56 PDT, Javier Fernandez	no flags	Details Formatted Diff Diff
Patch (45.92 KB, patch) 2018-04-20 05:03 PDT, Javier Fernandez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (3.02 MB, application/zip) 2018-04-20 06:05 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews103 for mac-sierra (2.30 MB, application/zip) 2018-04-20 06:09 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (15.09 MB, application/zip) 2018-04-20 06:31 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews115 for mac-sierra (3.07 MB, application/zip) 2018-04-20 06:45 PDT, EWS Watchlist	no flags	Details
Patch (83.38 KB, patch) 2018-04-20 07:26 PDT, Javier Fernandez	no flags	Details Formatted Diff Diff
Patch (83.40 KB, patch) 2018-04-20 11:49 PDT, Javier Fernandez	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Javier Fernandez

Comment 1 2018-04-20 04:56:22 PDT

Created attachment 338408 [details] Patch

Javier Fernandez

Comment 2 2018-04-20 05:03:50 PDT

Created attachment 338409 [details] Patch

EWS Watchlist

Comment 3 2018-04-20 06:05:53 PDT

Comment on attachment 338409 [details] Patch Attachment 338409 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7382260 New failing tests: imported/w3c/web-platform-tests/css/css-align/content-distribution/place-content-shorthand-001.html imported/w3c/web-platform-tests/css/css-align/self-alignment/place-self-shorthand-002.html imported/w3c/web-platform-tests/css/css-align/default-alignment/parse-justify-items-001.html imported/w3c/web-platform-tests/css/css-align/default-alignment/place-items-shorthand-002.html imported/w3c/web-platform-tests/css/css-align/default-alignment/place-items-shorthand-001.html imported/w3c/web-platform-tests/css/css-align/content-distribution/place-content-shorthand-002.html imported/w3c/web-platform-tests/css/css-align/self-alignment/place-self-shorthand-001.html imported/w3c/web-platform-tests/css/css-align/default-alignment/parse-justify-items-003.html imported/w3c/web-platform-tests/css/css-align/default-alignment/shorthand-serialization-001.html

EWS Watchlist

Comment 4 2018-04-20 06:05:54 PDT

Created attachment 338416 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 5 2018-04-20 06:09:58 PDT

Comment on attachment 338409 [details] Patch Attachment 338409 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7382414 New failing tests: imported/w3c/web-platform-tests/css/css-align/content-distribution/place-content-shorthand-001.html imported/w3c/web-platform-tests/css/css-align/self-alignment/place-self-shorthand-002.html imported/w3c/web-platform-tests/css/css-align/default-alignment/parse-justify-items-001.html imported/w3c/web-platform-tests/css/css-align/default-alignment/place-items-shorthand-002.html imported/w3c/web-platform-tests/css/css-align/default-alignment/place-items-shorthand-001.html imported/w3c/web-platform-tests/css/css-align/content-distribution/place-content-shorthand-002.html imported/w3c/web-platform-tests/css/css-align/self-alignment/place-self-shorthand-001.html imported/w3c/web-platform-tests/css/css-align/default-alignment/parse-justify-items-003.html imported/w3c/web-platform-tests/css/css-align/default-alignment/shorthand-serialization-001.html

EWS Watchlist

Comment 6 2018-04-20 06:09:59 PDT

Created attachment 338417 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 7 2018-04-20 06:31:28 PDT

Comment on attachment 338409 [details] Patch Attachment 338409 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7382377 New failing tests: imported/w3c/web-platform-tests/css/css-align/content-distribution/place-content-shorthand-001.html imported/w3c/web-platform-tests/css/css-align/self-alignment/place-self-shorthand-002.html imported/w3c/web-platform-tests/css/css-align/default-alignment/parse-justify-items-001.html imported/w3c/web-platform-tests/css/css-align/default-alignment/place-items-shorthand-002.html imported/w3c/web-platform-tests/css/css-align/default-alignment/place-items-shorthand-001.html imported/w3c/web-platform-tests/css/css-align/content-distribution/place-content-shorthand-002.html imported/w3c/web-platform-tests/css/css-align/self-alignment/place-self-shorthand-001.html imported/w3c/web-platform-tests/css/css-align/default-alignment/parse-justify-items-003.html imported/w3c/web-platform-tests/css/css-align/default-alignment/shorthand-serialization-001.html

EWS Watchlist

Comment 8 2018-04-20 06:31:30 PDT

Created attachment 338418 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

EWS Watchlist

Comment 9 2018-04-20 06:45:51 PDT

Comment on attachment 338409 [details] Patch Attachment 338409 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7382554 New failing tests: imported/w3c/web-platform-tests/css/css-align/content-distribution/place-content-shorthand-001.html imported/w3c/web-platform-tests/css/css-align/self-alignment/place-self-shorthand-002.html imported/w3c/web-platform-tests/css/css-align/default-alignment/parse-justify-items-001.html imported/w3c/web-platform-tests/css/css-align/default-alignment/place-items-shorthand-002.html imported/w3c/web-platform-tests/css/css-align/default-alignment/place-items-shorthand-001.html imported/w3c/web-platform-tests/css/css-align/content-distribution/place-content-shorthand-002.html imported/w3c/web-platform-tests/css/css-align/self-alignment/place-self-shorthand-001.html imported/w3c/web-platform-tests/css/css-align/default-alignment/parse-justify-items-003.html imported/w3c/web-platform-tests/css/css-align/default-alignment/shorthand-serialization-001.html

EWS Watchlist

Comment 10 2018-04-20 06:45:53 PDT

Created attachment 338420 [details] Archive of layout-test-results from ews115 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6

Javier Fernandez

Comment 11 2018-04-20 07:26:59 PDT

Created attachment 338424 [details] Patch

Antti Koivisto

Comment 12 2018-04-20 07:53:21 PDT

Comment on attachment 338424 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338424&action=review > Source/WebCore/ChangeLog:3 > + Update shorthands to the spec now that they are not ambiguous The title should indicate this is specifically about alignment shorthands.

Javier Fernandez

Comment 13 2018-04-20 11:49:44 PDT

Created attachment 338445 [details] Patch

WebKit Commit Bot

Comment 14 2018-04-20 13:06:58 PDT

Comment on attachment 338445 [details] Patch Clearing flags on attachment: 338445 Committed r230848: <https://trac.webkit.org/changeset/230848>

WebKit Commit Bot

Comment 15 2018-04-20 13:07:00 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 16 2018-04-20 13:09:36 PDT

<rdar://problem/39606274>

Note You need to log in before you can comment on or make changes to this bug.