Bug 184809

Summary: [AsyncScrolling] Add generic ScrollingThread implementation
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, ews-watchlist, fred.wang, jamesr, luiz, tonikitoo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Zan Dobersek
Reported 2018-04-19 23:08:22 PDT
[AsyncScrolling] Add generic ScrollingThread implementation
Attachments
Patch (6.37 KB, patch)
2018-04-19 23:14 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (6.23 KB, patch)
2018-04-19 23:41 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2018-04-19 23:14:53 PDT
Created attachment 338398 [details] Patch
EWS Watchlist
Comment 2 2018-04-19 23:17:02 PDT
Attachment 338398 [details] did not pass style-queue: ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:90: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:90: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/scrolling/generic/ScrollingThreadGeneric.cpp:48: More than one command on the same line [whitespace/newline] [4] Total errors found: 3 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Zan Dobersek
Comment 3 2018-04-19 23:41:46 PDT
Created attachment 338399 [details] Patch
EWS Watchlist
Comment 4 2018-04-19 23:44:41 PDT
Attachment 338399 [details] did not pass style-queue: ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:90: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:90: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/scrolling/generic/ScrollingThreadGeneric.cpp:48: More than one command on the same line [whitespace/newline] [4] Total errors found: 3 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 5 2018-04-20 01:17:13 PDT
Comment on attachment 338399 [details] Patch r=me
Zan Dobersek
Comment 6 2018-04-22 23:48:40 PDT
Comment on attachment 338399 [details] Patch Clearing flags on attachment: 338399 Committed r230905: <https://trac.webkit.org/changeset/230905>
Zan Dobersek
Comment 7 2018-04-22 23:48:44 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-04-22 23:49:18 PDT
<rdar://problem/39637604>
Note You need to log in before you can comment on or make changes to this bug.