Bug 184789

Summary: Enable Objective-C weak references
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebCore Misc.Assignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: CLOSED FIXED    
Severity: Normal CC: aestes, darin, dino, eric.carlson, ews-watchlist, graouts, keith_miller, kondapallykalyan, mark.lam, mitz, msaboff, saam, sam, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=221107
Bug Depends on:    
Bug Blocks: 184799    
Attachments:
Description Flags
Patch v1 mitz: review+

David Kilzer (:ddkilzer)
Reported 2018-04-19 11:58:34 PDT
Enable Objective-C weak references in the WebKit project as a baby step towards enabling ARC. This will let the WebKit project use the 'weak' attribute with Objective-C properties prior to enabling ARC. (Where ARC is already enabled in a couple of test projects, we don't explicitly re-enable weak references as ARC already provides them.)
Attachments
Patch v1 (20.57 KB, patch)
2018-04-19 12:08 PDT, David Kilzer (:ddkilzer) 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-04-19 11:58:49 PDT
<rdar://problem/39571716>
David Kilzer (:ddkilzer)
Comment 2 2018-04-19 12:08:42 PDT
Created attachment 338348 [details] Patch v1
EWS Watchlist
Comment 3 2018-04-19 12:10:16 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
David Kilzer (:ddkilzer)
Comment 4 2018-04-19 15:54:14 PDT
Committed r230824: <https://trac.webkit.org/changeset/230824>
Note You need to log in before you can comment on or make changes to this bug.