Bug 184762

Summary: Don't put build products into WK_ALTERNATE_WEBKIT_SDK_PATH for engineering builds
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, dino, ews-watchlist, graouts, keith_miller, kondapallykalyan, mark.lam, mitz, msaboff, saam, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch mitz: review+

Jer Noble
Reported 2018-04-18 16:44:57 PDT
Don't put build products into WK_ALTERNATE_WEBKIT_SDK_PATH for engineering builds
Attachments
Patch (20.29 KB, patch)
2018-04-18 16:49 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (18.09 KB, patch)
2018-04-19 10:18 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (18.31 KB, patch)
2018-04-19 11:10 PDT, Jer Noble 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2018-04-18 16:49:03 PDT
Created attachment 338278 [details] Patch
Jer Noble
Comment 2 2018-04-19 10:18:37 PDT
Created attachment 338337 [details] Patch
EWS Watchlist
Comment 3 2018-04-19 10:20:56 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Radar WebKit Bug Importer
Comment 4 2018-04-19 10:22:03 PDT
<rdar://problem/39568077>
mitz
Comment 5 2018-04-19 10:23:50 PDT
Comment on attachment 338337 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338337&action=review > Source/ThirdParty/ANGLE/Configurations/Base.xcconfig:76 > +ANGLE_INSTALL_PATH_PREFIX_Production = $(ANGLE_INSTALL_PATH_PREFIX_Production_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR)); This (and the reset of them) should be keyed off DEPLOYMENT_LOCATION rather than CONFIGURATION (like the script build phase above).
Jer Noble
Comment 6 2018-04-19 11:10:14 PDT
Created attachment 338344 [details] Patch
mitz
Comment 7 2018-04-19 11:37:08 PDT
Comment on attachment 338344 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338344&action=review > Source/WebCore/PAL/Configurations/CopyPALHeaders.xcconfig:28 > +PRIVATE_HEADERS_FOLDER_PATH = $(PAL_INSTALL_PATH_PREFIX)/usr/local/include/pal; I think you end up with a harmless extra slash there.
Jer Noble
Comment 8 2018-04-20 15:14:48 PDT
Committed r230858: <https://trac.webkit.org/changeset/230858>
Note You need to log in before you can comment on or make changes to this bug.