Bug 184743
| Summary: | Remove the style checker rule for using release assert with security implication | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED LATER | ||
| Severity: | Normal | CC: | ap, bfulgham, ddkilzer, jonlee, lforschler |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
https://trac.webkit.org/changeset/223421/webkit made it so that style check emits an error
whenever ASSERT_WITH_SECURITY_IMPLICATION is used instead of RELEASE_ASSERT_WITH_SECURITY_IMPLICATION.
I don't think we should have this style rule since using ASSERT_WITH_SECURITY_IMPLICATION
is a valid thing to do when there is a significant perf cost.
We've already had a perf regression from people mindlessly fixing this style error.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |