Bug 184719

Summary: Don't activate selection on become first responder
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, thorton, timothy, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Megan Gardner
Reported 2018-04-17 17:07:50 PDT
Don't activate selection on become first responder
Attachments
Patch (1.93 KB, patch)
2018-04-17 17:13 PDT, Megan Gardner 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2018-04-17 17:13:21 PDT
Created attachment 338164 [details] Patch
Megan Gardner
Comment 2 2018-04-17 17:14:06 PDT
I also talked with Morgan and he agrees that this is reasonable to do.
Tim Horton
Comment 3 2018-04-17 17:37:05 PDT
Comment on attachment 338164 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338164&action=review > Source/WebKit/ChangeLog:9 > + as there are not guaranteed to have selection rects immediately due to async/two process architecture. The selection as there? > Source/WebKit/ChangeLog:11 > + in the past because this selection assistant was only for editable text, which would immediately set a carat, which caret! This is not gold. > Source/WebKit/ChangeLog:12 > + counted at a selection. Now that this is for non-editable text as well, activating the selection is problematic. Counted!?
Radar WebKit Bug Importer
Comment 4 2018-04-17 18:03:46 PDT
<rdar://problem/39512619>
Megan Gardner
Comment 5 2018-04-17 18:04:04 PDT
https://webkit.org/b/184719
Megan Gardner
Comment 6 2018-04-17 18:04:19 PDT
https://trac.webkit.org/r230745
Note You need to log in before you can comment on or make changes to this bug.