Bug 18471

Summary: Fix WebDownload.cpp compile problems for cairo/curl build
Product: WebKit Reporter: Daniel Zucker <zucker>
Component: PlatformAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: ahya365, bfulgham
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 17730    
Attachments:
Description Flags
divide WebDownload.cpp into WebDownloadCurl.cpp and WebDownloadCFNet.cpp aroben: review-

Daniel Zucker
Reported 2008-04-13 21:58:25 PDT
This patch replaces WebDownload.cpp with WebDownloadCFNet.cpp and WebDownloadCurl.cpp. WebDownloadCFNet.cpp is unchanged. WebDownloadCurl.cpp removes some function implementations and replaces them with stubs. WebKit.vcproj is also modified to include/exclude the appropriate files from the appropriate build configurations.
Attachments
divide WebDownload.cpp into WebDownloadCurl.cpp and WebDownloadCFNet.cpp (118.18 KB, patch)
2008-04-13 21:59 PDT, Daniel Zucker 		aroben: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Zucker
Comment 1 2008-04-13 21:59:08 PDT
Created attachment 20518 [details] divide WebDownload.cpp into WebDownloadCurl.cpp and WebDownloadCFNet.cpp
Adam Roben (:aroben)
Comment 2 2008-04-14 08:11:23 PDT
Comment on attachment 20518 [details] divide WebDownload.cpp into WebDownloadCurl.cpp and WebDownloadCFNet.cpp It looks like this patch has a mixture of spaces and tabs in it. Please only use 4 spaces for indentation. I think we'd ultimately be better served by moving the concept of a "download" to WebCore and having the platform differences reside at that level. Having two whole implementations of WebDownload doesn't feel like the right solution to me.
Brent Fulgham
Comment 3 2009-08-11 22:47:50 PDT
This work (or a facsimile of this) is now part of WebKit. Marking this as a duplicate and closing. *** This bug has been marked as a duplicate of bug 23092 ***
Note You need to log in before you can comment on or make changes to this bug.