Bug 18471

Summary:

Fix WebDownload.cpp compile problems for cairo/curl build

Product:

WebKit

Reporter:

Daniel Zucker <zucker>

Component:

Platform

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

ahya365, bfulgham

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

17730

Attachments:

Description	Flags
divide WebDownload.cpp into WebDownloadCurl.cpp and WebDownloadCFNet.cpp	aroben: review-

Description Daniel Zucker 2008-04-13 21:58:25 PDT

This patch replaces WebDownload.cpp with WebDownloadCFNet.cpp and WebDownloadCurl.cpp.  WebDownloadCFNet.cpp is unchanged.  WebDownloadCurl.cpp removes some function implementations and replaces them with stubs.  WebKit.vcproj is also modified to include/exclude the appropriate files from the appropriate build configurations.

Comment 1 Daniel Zucker 2008-04-13 21:59:08 PDT

Created attachment 20518 [details]
divide WebDownload.cpp into WebDownloadCurl.cpp and WebDownloadCFNet.cpp

Comment 2 Adam Roben (:aroben) 2008-04-14 08:11:23 PDT

Comment on attachment 20518 [details]
divide WebDownload.cpp into WebDownloadCurl.cpp and WebDownloadCFNet.cpp

It looks like this patch has a mixture of spaces and tabs in it. Please only use 4 spaces for indentation.

I think we'd ultimately be better served by moving the concept of a "download" to WebCore and having the platform differences reside at that level. Having two whole implementations of WebDownload doesn't feel like the right solution to me.

Comment 3 Brent Fulgham 2009-08-11 22:47:50 PDT

This work (or a facsimile of this) is now part of WebKit.  Marking this as a duplicate and closing.

*** This bug has been marked as a duplicate of bug 23092 ***