Summary: | [GTK] Generate a JSC bundle on the 64 and 32 bit release bots and upload it to webkitgtk.org | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> | ||||||
Component: | Tools / Tests | Assignee: | Carlos Alberto Lopez Perez <clopez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aakash_jain, ap, bugs-noreply, clopez, dbates, ews-watchlist, gustavo, lforschler, mathias, ossy, psaavedra, webkit-bug-importer, ysuzuki | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=179945 https://bugs.webkit.org/show_bug.cgi?id=213615 |
||||||||
Attachments: |
|
Description
Carlos Alberto Lopez Perez
2018-04-17 09:54:39 PDT
Created attachment 338131 [details]
Patch
Attachment 338131 [details] did not pass style-queue:
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/factories.py:66: [BuildFactory.__init__] Undefined variable 'GenerateJSCBundle' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/factories.py:101: [TestFactory.__init__] Undefined variable 'GenerateJSCBundle' [pylint/E0602] [5]
Total errors found: 2 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to Build Bot from comment #2) > Attachment 338131 [details] did not pass style-queue: > > > ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/factories.py:66: > [BuildFactory.__init__] Undefined variable 'GenerateJSCBundle' > [pylint/E0602] [5] > ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/factories.py:101: > [TestFactory.__init__] Undefined variable 'GenerateJSCBundle' > [pylint/E0602] [5] > Total errors found: 2 in 6 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. BTW, this warnings are incorrect. GenerateJSCBundle() is implemented on steps.py but the tool seems confused with that. I double-checked with the script run-buildbot-test.py that the master starts fine with this config changes and does what is expected. Created attachment 338136 [details]
Patch
Patch v2, minor cosmetic changes on the script
Attachment 338136 [details] did not pass style-queue:
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/factories.py:66: [BuildFactory.__init__] Undefined variable 'GenerateJSCBundle' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/factories.py:101: [TestFactory.__init__] Undefined variable 'GenerateJSCBundle' [pylint/E0602] [5]
Total errors found: 2 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 338136 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338136&action=review LGTM, and I installed the packages and deployed the file in 32bot =) sorry for the delay! > Tools/Scripts/generate-jsc-bundle:124 > + # Clean everthing from previous runs everything* > Tools/Scripts/generate-jsc-bundle:142 > + # jsvu project preffers .zip rather than .tar.xz prefers* Interesting, I wasn't aware of jsvu =) Committed r231230: <https://trac.webkit.org/changeset/231230> Committed r231256: <https://trac.webkit.org/changeset/231256> |