Bug 184687

Summary: [GLIB] Make it possible to handle JSCClass external properties not added to the prototype
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, ews-watchlist, keith_miller, mark.lam, mcatanzaro, msaboff, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: Gtk, InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mcatanzaro: review+, ews-watchlist: commit-queue-

Carlos Garcia Campos
Reported 2018-04-17 01:45:12 PDT
This is required to implement dynamic properties that can't be added with jsc_class_add_property() for example to implement something like imports object in seed/gjs.
Attachments
Patch (56.43 KB, patch)
2018-04-17 01:52 PDT, Carlos Garcia Campos 		mcatanzaro: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2018-04-17 01:52:54 PDT
Created attachment 338092 [details] Patch
EWS Watchlist
Comment 2 2018-04-17 03:07:06 PDT
Comment on attachment 338092 [details] Patch Attachment 338092 [details] did not pass jsc-ews (mac): Output: http://webkit-queues.webkit.org/results/7341696 New failing tests: stress/ftl-get-by-id-getter-exception-interesting-live-state.js.ftl-eager-no-cjit
Carlos Garcia Campos
Comment 3 2018-04-17 23:51:46 PDT
Committed r230753: <https://trac.webkit.org/changeset/230753>
Radar WebKit Bug Importer
Comment 4 2018-04-17 23:52:22 PDT
<rdar://problem/39519419>
Note You need to log in before you can comment on or make changes to this bug.