Bug 184674

Summary: Commit order should always be returned by api.
Product: WebKit Reporter: dewei_zhu
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: dewei_zhu, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 183888    
Attachments:
Description Flags
Patch rniwa: review+

Description dewei_zhu 2018-04-16 17:08:24 PDT
Commit order should always be returned by api.
Comment 1 dewei_zhu 2018-04-16 17:13:45 PDT
Created attachment 338061 [details]
Patch
Comment 2 Ryosuke Niwa 2018-04-17 02:44:14 PDT
Comment on attachment 338061 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338061&action=review

> Websites/perf.webkit.org/public/api/measurement-set.php:223
> +            $order = !strlen($trimmed_order) ? NULL : intval($trimmed_order);

I think it's a little more straight forward to do: strlen($trimmed_order) ? intval($trimmed_order) : NULL.