| Summary: | PutStackSinkingPhase should know that KillStack means ConflictingFlush | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||
| Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Filip Pizlo
2018-04-16 16:10:13 PDT
Created attachment 338062 [details]
possible patch
Created attachment 338068 [details]
the patch
Created attachment 338143 [details]
the patch
Decided to be even more conservative and change clobberize for KillStack.
This is all perf neutral so it's probably worth it for the correctness.
Comment on attachment 338143 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=338143&action=review r=me > Source/JavaScriptCore/ChangeLog:20 > + KillStack along one path frough the CFG. Also, the definition of DeadFlush and ConflictingFlush in the comment Spelling *frough* |