Bug 184672

Summary: PutStackSinkingPhase should know that KillStack means ConflictingFlush
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
possible patch
none
the patch
none
the patch msaboff: review+

Filip Pizlo
Reported 2018-04-16 16:10:13 PDT
Patch forthcoming.
Attachments
possible patch (6.24 KB, patch)
2018-04-16 17:16 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (9.83 KB, patch)
2018-04-16 18:54 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (8.01 KB, patch)
2018-04-17 12:37 PDT, Filip Pizlo 		msaboff: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2018-04-16 17:16:55 PDT
Created attachment 338062 [details] possible patch
Filip Pizlo
Comment 2 2018-04-16 18:54:58 PDT
Created attachment 338068 [details] the patch
Filip Pizlo
Comment 3 2018-04-17 12:37:11 PDT
Created attachment 338143 [details] the patch Decided to be even more conservative and change clobberize for KillStack. This is all perf neutral so it's probably worth it for the correctness.
Michael Saboff
Comment 4 2018-04-17 12:46:42 PDT
Comment on attachment 338143 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=338143&action=review r=me > Source/JavaScriptCore/ChangeLog:20 > + KillStack along one path frough the CFG. Also, the definition of DeadFlush and ConflictingFlush in the comment Spelling *frough*
Filip Pizlo
Comment 5 2018-04-17 12:53:59 PDT
Landed in https://trac.webkit.org/changeset/230725/webkit
Radar WebKit Bug Importer
Comment 6 2018-04-17 12:54:17 PDT
<rdar://problem/39500467>
Note You need to log in before you can comment on or make changes to this bug.