Bug 184669

Summary: Add system trace points for process launch and for initializeWebProcess
Product: WebKit Reporter: Saam Barati <saam>
Component: WebKit2Assignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, fpizlo, ggaren, japhet, joepeck, keith_miller, mark.lam, msaboff, rniwa, sam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
patch
saam: review-
patch
none
patch
none
Archive of layout-test-results from ews200 for win-future none

Saam Barati
Reported 2018-04-16 14:27:36 PDT
I've been using this locally, and it's helpful. We should just commit it.
Attachments
WIP (1.92 KB, patch)
2018-04-16 15:18 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (11.48 KB, patch)
2018-04-16 16:00 PDT, Saam Barati 		saam: review-
DetailsFormatted DiffDiff
patch (11.49 KB, patch)
2018-04-16 16:39 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (11.84 KB, patch)
2018-04-16 17:09 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews200 for win-future (12.94 MB, application/zip)
2018-04-16 18:23 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2018-04-16 15:18:07 PDT
Created attachment 338045 [details] WIP Just dropping this here because I need to revert these files locally. I seem to have lost the full patch. I'll rewrite it in a bit.
Saam Barati
Comment 2 2018-04-16 16:00:28 PDT
Created attachment 338053 [details] patch
Saam Barati
Comment 3 2018-04-16 16:00:49 PDT
I haven't tried compiling this locally, so I'll let EWS let me know if I messed it up.
Simon Fraser (smfr)
Comment 4 2018-04-16 16:05:56 PDT
Comment on attachment 338053 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=338053&action=review > Source/WebKit/WebProcess/WebProcess.cpp:282 > + TraceScope traceScope(ProcessLaunchStart, ProcessLaunchEnd); You're using the same codes for both UI and web process sides. I think this will result in confusion; you should use different codes.
Saam Barati
Comment 5 2018-04-16 16:37:22 PDT
Comment on attachment 338053 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=338053&action=review >> Source/WebKit/WebProcess/WebProcess.cpp:282 >> + TraceScope traceScope(ProcessLaunchStart, ProcessLaunchEnd); > > You're using the same codes for both UI and web process sides. I think this will result in confusion; you should use different codes. Yeah this is a copy paste bug. It should be InitializeWebProcessStart/End I'll fix it locally.
Saam Barati
Comment 6 2018-04-16 16:38:39 PDT
Comment on attachment 338053 [details] patch Will just upload a new patch
Saam Barati
Comment 7 2018-04-16 16:39:30 PDT
Created attachment 338055 [details] patch
Saam Barati
Comment 8 2018-04-16 17:09:46 PDT
Created attachment 338059 [details] patch
EWS Watchlist
Comment 9 2018-04-16 18:23:09 PDT
Comment on attachment 338059 [details] patch Attachment 338059 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7337531 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html
EWS Watchlist
Comment 10 2018-04-16 18:23:21 PDT
Created attachment 338067 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Saam Barati
Comment 11 2018-04-16 19:14:04 PDT
(In reply to Build Bot from comment #9) > Comment on attachment 338059 [details] > patch > > Attachment 338059 [details] did not pass win-ews (win): > Output: http://webkit-queues.webkit.org/results/7337531 > > New failing tests: > http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html This is definitely not my patch.
WebKit Commit Bot
Comment 12 2018-04-17 08:57:38 PDT
Comment on attachment 338059 [details] patch Clearing flags on attachment: 338059 Committed r230711: <https://trac.webkit.org/changeset/230711>
WebKit Commit Bot
Comment 13 2018-04-17 08:57:40 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 14 2018-04-17 08:59:26 PDT
<rdar://problem/39491891>
Note You need to log in before you can comment on or make changes to this bug.