Bug 184667

Summary: Ignore test262 test results associated with Test262 runner
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, leo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 183343    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Michael Saboff
Reported 2018-04-16 13:55:50 PDT
The test results from Test262 runner are 7MB and WebKit bugzilla doesn't like that large of test file. This bug is to land that file separate from the main test262 runner changes.
Attachments
Patch (967 bytes, patch)
2018-04-18 09:13 PDT, Leo Balter 		no flags
DetailsFormatted DiffDiff
Patch (968 bytes, patch)
2018-04-18 09:14 PDT, Leo Balter 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Leo Balter
Comment 1 2018-04-18 09:13:56 PDT
Created attachment 338219 [details] Patch
Leo Balter
Comment 2 2018-04-18 09:14:54 PDT
Created attachment 338220 [details] Patch
Leo Balter
Comment 3 2018-04-18 09:18:38 PDT
I added a small patch suggestion we just ignore the results file. I've been thinking here and I believe this file is good for consuming manually or through CI but those would need to perform a full run to collect the most accurate results anyway. For now, I can't see a good argument to have this file merged unless you prefer otherwise.
Michael Saboff
Comment 4 2018-04-24 12:21:49 PDT
Comment on attachment 338220 [details] Patch r=me
WebKit Commit Bot
Comment 5 2018-04-24 12:49:06 PDT
Comment on attachment 338220 [details] Patch Clearing flags on attachment: 338220 Committed r230967: <https://trac.webkit.org/changeset/230967>
WebKit Commit Bot
Comment 6 2018-04-24 12:49:07 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-04-24 12:50:24 PDT
<rdar://problem/39694143>
Note You need to log in before you can comment on or make changes to this bug.