Bug 184657

Summary: Clean up OTHER_LDFLAGS for WebKit processes
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: WebKit Misc.Assignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, jer.noble, mitz, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Timothy Hatcher 2018-04-16 10:28:51 PDT 
Change how OTHER_LDFLAGS adds additional frameworks to match WebKit.
Comment 1 Timothy Hatcher 2018-04-16 10:33:15 PDT 
Created attachment 338012 [details]
Patch
Comment 2 WebKit Commit Bot 2018-04-16 11:29:26 PDT 
Comment on attachment 338012 [details]
Patch

Clearing flags on attachment: 338012

Committed r230673: <https://trac.webkit.org/changeset/230673>
Comment 3 WebKit Commit Bot 2018-04-16 11:29:28 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-04-16 11:30:28 PDT 
<rdar://problem/39463307>
Comment 5 Saam Barati 2018-04-16 19:08:28 PDT 
This broke 32-bit Mac build (i386).
Comment 7 Saam Barati 2018-04-16 19:11:37 PDT 
EWS also said this patch was broken :-(
Comment 8 Timothy Hatcher 2018-04-16 19:20:07 PDT 
Broke the 32-bit Mac build.
Comment 9 Timothy Hatcher 2018-04-16 19:22:28 PDT 
Created attachment 338071 [details]
Patch
Comment 10 WebKit Commit Bot 2018-04-16 20:01:13 PDT 
Comment on attachment 338071 [details]
Patch

Clearing flags on attachment: 338071

Committed r230698: <https://trac.webkit.org/changeset/230698>
Comment 11 WebKit Commit Bot 2018-04-16 20:01:15 PDT 
All reviewed patches have been landed.  Closing bug.