Bug 184657

Summary: Clean up OTHER_LDFLAGS for WebKit processes
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: WebKit Misc.Assignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, jer.noble, mitz, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Timothy Hatcher
Reported 2018-04-16 10:28:51 PDT
Change how OTHER_LDFLAGS adds additional frameworks to match WebKit.
Attachments
Patch (5.78 KB, patch)
2018-04-16 10:33 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Patch (1.55 KB, patch)
2018-04-16 19:22 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2018-04-16 10:33:15 PDT
Created attachment 338012 [details] Patch
WebKit Commit Bot
Comment 2 2018-04-16 11:29:26 PDT
Comment on attachment 338012 [details] Patch Clearing flags on attachment: 338012 Committed r230673: <https://trac.webkit.org/changeset/230673>
WebKit Commit Bot
Comment 3 2018-04-16 11:29:28 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2018-04-16 11:30:28 PDT
<rdar://problem/39463307>
Saam Barati
Comment 5 2018-04-16 19:08:28 PDT
This broke 32-bit Mac build (i386).
Saam Barati
Comment 7 2018-04-16 19:11:37 PDT
EWS also said this patch was broken :-(
Timothy Hatcher
Comment 8 2018-04-16 19:20:07 PDT
Broke the 32-bit Mac build.
Timothy Hatcher
Comment 9 2018-04-16 19:22:28 PDT
Created attachment 338071 [details] Patch
WebKit Commit Bot
Comment 10 2018-04-16 20:01:13 PDT
Comment on attachment 338071 [details] Patch Clearing flags on attachment: 338071 Committed r230698: <https://trac.webkit.org/changeset/230698>
WebKit Commit Bot
Comment 11 2018-04-16 20:01:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.