| Summary: | [WPE] Build and link against latest WPEBackend and WPEBackend-fdo | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||||||||||||||||
| Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||
| Severity: | Normal | CC: | bugs-noreply, commit-queue, ews-watchlist, mcatanzaro, webkit-bug-importer | ||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||
| Bug Depends on: | |||||||||||||||||||||||
| Bug Blocks: | 178894 | ||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||
|
Description
Zan Dobersek
2018-04-16 00:00:53 PDT
Created attachment 337990 [details]
Patch
Comment on attachment 337990 [details]
Patch
I could wait for WPEBackend-fdo to also become versioned, and do all this in one go.
That was my plan, but this is fine too. I got backlogged with other work, will try to care for WPEBackend-fdo soon. Created attachment 338709 [details]
Patch
Notes: * I left export_linux_dmabuf unimplemented in HeadlessViewBackend, which is probably bad. No clue how to handle that. * I'll update the JHBuild moduleset again before landing. Hm, I forgot to update dyz. Created attachment 338727 [details]
Patch
(In reply to Michael Catanzaro from comment #7) > Created attachment 338727 [details] > Patch This should fix dyz. I'm still expecting EWS to fail, though: this will probably need a clean build. Created attachment 338728 [details]
Patch
(In reply to Michael Catanzaro from comment #5) > Notes: > > * I left export_linux_dmabuf unimplemented in HeadlessViewBackend, which is > probably bad. No clue how to handle that. Reverted the WPEBackend-fdo commits that added this API > * I'll update the JHBuild moduleset again before landing. Done (no longer uses my fork of WebPlatformForEmbedded/WPEBackend repo) Created attachment 338731 [details]
Patch
Created attachment 338736 [details]
Patch
Created attachment 338738 [details]
Patch
(In reply to Michael Catanzaro from comment #13) > Created attachment 338738 [details] > Patch Still doesn't complete a clean build: In file included from /home/zan/Work/webkit/git/Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:29:0: ../../Tools/wpe/HeadlessViewBackend/HeadlessViewBackend.h:35:21: fatal error: wpe/fdo.h: No such file or directory #include <wpe/fdo.h> ^ compilation terminated. Does `find_package(WPEBackend-fdo REQUIRED)` have to be called separately in Tools/WebKitTestRunner/PlatformWPE.cmake? Did you try 'rm -rf WebKitBuild/' before you started? (In reply to Zan Dobersek from comment #14) > Does `find_package(WPEBackend-fdo REQUIRED)` have to be called separately in > Tools/WebKitTestRunner/PlatformWPE.cmake? No, once in OptionsWPE.cmake is enough. I suspect you just need a clean build. Let me try testing a release build; I've only checked a debug build so far. Comment on attachment 338738 [details] Patch Attachment 338738 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7456112 New failing tests: compositing/debug-borders-dynamic.html Created attachment 338780 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
OK, I actually get the same error in a release build. (In reply to Zan Dobersek from comment #14) > Does `find_package(WPEBackend-fdo REQUIRED)` have to be called separately in > Tools/WebKitTestRunner/PlatformWPE.cmake? And I missed that these were testing-only dependencies.... (In reply to Zan Dobersek from comment #14) > Does `find_package(WPEBackend-fdo REQUIRED)` have to be called separately in > Tools/WebKitTestRunner/PlatformWPE.cmake? You were right, that's all that's required. Created attachment 338794 [details]
Patch
EWS failure is expected, Adrian will restart the WPE EWS after this lands. Comment on attachment 338794 [details] Patch Clearing flags on attachment: 338794 Committed r231042: <https://trac.webkit.org/changeset/231042> All reviewed patches have been landed. Closing bug. |