Bug 184637

Summary: [Cocoa] Adopt CCRSAGetCRTComponents and stop using CCBigNum
Product: WebKit Reporter: Darin Adler <darin>
Component: WebCore Misc.Assignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bfulgham, ews-watchlist, jiewen_tan, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=201250
Attachments:
Description Flags
Patch
ap: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews100 for mac-sierra none

Darin Adler
Reported 2018-04-15 13:04:46 PDT
[Cocoa] Adopt CCRSAGetCRTComponents and stop using CCBigNum
Attachments
Patch (7.66 KB, patch)
2018-04-15 13:07 PDT, Darin Adler 		ap: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews100 for mac-sierra (2.22 MB, application/zip)
2018-04-15 14:12 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2018-04-15 13:07:14 PDT
Created attachment 337974 [details] Patch
Darin Adler
Comment 2 2018-04-15 13:09:11 PDT
<rdar://problem/22670286>
Darin Adler
Comment 3 2018-04-15 13:09:24 PDT
I compiled this, but didn’t test it yet because I don’t know how.
EWS Watchlist
Comment 4 2018-04-15 14:12:29 PDT
Comment on attachment 337974 [details] Patch Attachment 337974 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7324829 New failing tests: animations/needs-layout.html
EWS Watchlist
Comment 5 2018-04-15 14:12:30 PDT
Created attachment 337976 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
Alexey Proskuryakov
Comment 6 2018-04-15 16:20:28 PDT
Comment on attachment 337974 [details] Patch Please run tests in crypto subdirectory before landing, as EWS doesn't exercise 10.13+ only code.
Darin Adler
Comment 7 2018-04-26 09:13:22 PDT
I ran the crypto tests on macOS with 10.13.5 (an internal pre-release version, but should be fine) and all of them passed.
Darin Adler
Comment 8 2018-04-26 09:14:42 PDT
Committed r231046: <https://trac.webkit.org/changeset/231046>
Radar WebKit Bug Importer
Comment 9 2018-04-26 09:15:32 PDT
<rdar://problem/39759473>
Note You need to log in before you can comment on or make changes to this bug.