Summary: | [iOS] Add API tests for PDF find-in-page | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andy Estes <aestes> | ||||||||
Component: | New Bugs | Assignee: | Andy Estes <aestes> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bdakin, commit-queue, ews-watchlist, mitz, rniwa, thorton, timothy, webkit-bug-importer, wenson_hsieh, youennf | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Andy Estes
2018-04-14 22:12:02 PDT
Created attachment 337970 [details]
Patch
Comment on attachment 337970 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337970&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:114 > + auto webView = adoptNS([[WKWebView alloc] initWithFrame:CGRectZero]); Can just use -init. Comment on attachment 337970 [details] Patch Attachment 337970 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7320628 New failing tests: animations/needs-layout.html Created attachment 337971 [details]
Archive of layout-test-results from ews101 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 337973 [details]
Patch
The commit-queue encountered the following flaky tests while processing attachment 337973 [details]:
The commit-queue is continuing to process your patch.
The commit-queue encountered the following flaky tests while processing attachment 337973 [details]: animations/needs-layout.html bug 184638 (author: dino@apple.com) The commit-queue is continuing to process your patch. Comment on attachment 337973 [details] Patch Clearing flags on attachment: 337973 Committed r230663: <https://trac.webkit.org/changeset/230663> All reviewed patches have been landed. Closing bug. |