Bug 184634

Summary: [iOS] Add API tests for PDF find-in-page
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, ews-watchlist, mitz, rniwa, thorton, timothy, webkit-bug-importer, wenson_hsieh, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews101 for mac-sierra
none
Patch none

Description Andy Estes 2018-04-14 22:12:02 PDT
[iOS] Add API tests for PDF find-in-page
Comment 1 Andy Estes 2018-04-14 22:14:20 PDT
Created attachment 337970 [details]
Patch
Comment 2 mitz 2018-04-14 22:22:11 PDT
Comment on attachment 337970 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337970&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:114
> +    auto webView = adoptNS([[WKWebView alloc] initWithFrame:CGRectZero]);

Can just use -init.
Comment 3 EWS Watchlist 2018-04-14 23:20:04 PDT
Comment on attachment 337970 [details]
Patch

Attachment 337970 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7320628

New failing tests:
animations/needs-layout.html
Comment 4 EWS Watchlist 2018-04-14 23:20:05 PDT
Created attachment 337971 [details]
Archive of layout-test-results from ews101 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 5 Andy Estes 2018-04-15 10:55:07 PDT
Created attachment 337973 [details]
Patch
Comment 6 WebKit Commit Bot 2018-04-15 11:44:47 PDT
The commit-queue encountered the following flaky tests while processing attachment 337973 [details]:

The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2018-04-15 14:21:22 PDT
The commit-queue encountered the following flaky tests while processing attachment 337973 [details]:

animations/needs-layout.html bug 184638 (author: dino@apple.com)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2018-04-15 14:21:56 PDT
Comment on attachment 337973 [details]
Patch

Clearing flags on attachment: 337973

Committed r230663: <https://trac.webkit.org/changeset/230663>
Comment 9 WebKit Commit Bot 2018-04-15 14:21:58 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-04-15 14:22:36 PDT
<rdar://problem/39444421>