Bug 184623

Summary: [GTK][WPE] Build is broken after r230640
Product: WebKit Reporter: Carlos Bentzen <cadubentzen>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, commit-queue, zan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Carlos Bentzen
Reported 2018-04-13 21:07:40 PDT
In the linking stage of MiniBrowser: /home/cadubentzen/git/github/webkit/WebKitBuild/gtk/Debug/lib/libwebkit2gtk-4.0.so: undefined reference to `WebKit::SuspendedPageProxy::SuspendedPageProxy(WebKit::WebPageProxy&, WebKit::WebProcessProxy&, WebKit::WebBackForwardListItem&)' /home/cadubentzen/git/github/webkit/WebKitBuild/gtk/Debug/lib/libwebkit2gtk-4.0.so: undefined reference to `WebKit::SuspendedPageProxy::loggingString() const' /home/cadubentzen/git/github/webkit/WebKitBuild/gtk/Debug/lib/libwebkit2gtk-4.0.so: undefined reference to `WebKit::SuspendedPageProxy::webProcessDidClose(WebKit::WebProcessProxy&)' /home/cadubentzen/git/github/webkit/WebKitBuild/gtk/Debug/lib/libwebkit2gtk-4.0.so: undefined reference to `WebKit::SuspendedPageProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&)' Because SuspendedPageProxy.h is included in WebProcessProxy.cpp but SuspendedPageProxy.cpp is not compiled via the CMake build.
Attachments
Patch (1.28 KB, patch)
2018-04-13 21:13 PDT, Carlos Bentzen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Bentzen
Comment 1 2018-04-13 21:13:51 PDT
Created attachment 337957 [details] Patch
WebKit Commit Bot
Comment 2 2018-04-14 00:00:59 PDT
Comment on attachment 337957 [details] Patch Clearing flags on attachment: 337957 Committed r230657: <https://trac.webkit.org/changeset/230657>
WebKit Commit Bot
Comment 3 2018-04-14 00:01:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.