Summary: | [JSC] Use {resolve,reject,promise} instead of {@resolve,@reject,@promise} | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
Status: | NEW --- | ||||||
Severity: | Normal | CC: | achristensen, ews-watchlist, joepeck, keith_miller, mark.lam, msaboff, saam | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Yusuke Suzuki
2018-04-13 10:45:51 PDT
Created attachment 337907 [details]
Patch
Comment on attachment 337907 [details] Patch Attachment 337907 [details] did not pass jsc-ews (mac): Output: http://webkit-queues.webkit.org/results/7307694 New failing tests: stress/ftl-get-by-id-getter-exception-interesting-live-state.js.ftl-eager (In reply to Build Bot from comment #2) > Comment on attachment 337907 [details] > Patch > > Attachment 337907 [details] did not pass jsc-ews (mac): > Output: http://webkit-queues.webkit.org/results/7307694 > > New failing tests: > stress/ftl-get-by-id-getter-exception-interesting-live-state.js.ftl-eager It is flaky test, and it’s not related to this patch. Ping? Ping review? Ping? Comment on attachment 337907 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337907&action=review > Source/JavaScriptCore/ChangeLog:12 > + We know that promise capabilities object has these own properties. > + So we do not need to use private names for these properties. This > + change reduces the usage of private named properties in our builtin > + JS, and only internal properties and special private properties (like, > + @charCodeAt) uses @xxx names. What's the benefit here? Seems better to err on the side of being more conservative. Comment on attachment 337907 [details]
Patch
This has been requesting review for more than one year. If this is still needed, please rebase and re-request review.
|