Bug 184559

Summary: Introduce SuspendedPageProxy to keep old web processes around after their WebPageProxy has been swapped to a new one
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, aestes, benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, japhet, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Brady Eidson
Reported 2018-04-12 15:36:14 PDT
Introduce SuspendedPageProxy to keep old web processes around after their WebPageProxy has been swapped to a new one This is an intermediate step towards: 1 - Keeping the page cache working 2 - Keeping an origin-keyed process pool around, ready to reuse.
Attachments
Patch (48.87 KB, patch)
2018-04-12 15:54 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (48.84 KB, patch)
2018-04-12 16:19 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (48.81 KB, patch)
2018-04-12 16:34 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (48.86 KB, patch)
2018-04-13 10:23 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (49.00 KB, patch)
2018-04-13 10:31 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2018-04-12 15:54:45 PDT Comment hidden (obsolete)
Brady Eidson
Comment 2 2018-04-12 16:19:17 PDT Comment hidden (obsolete)
Brady Eidson
Comment 3 2018-04-12 16:34:47 PDT
Created attachment 337850 [details] Patch
Alex Christensen
Comment 4 2018-04-13 08:09:54 PDT
Comment on attachment 337850 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337850&action=review > Source/WebCore/loader/DocumentLoader.cpp:659 > + completionHandler(WTFMove(newRequest)); At this point completionHandler has been moved into navigationPolicyCompletionHandler, right? > Source/WebCore/loader/FrameLoader.cpp:3234 > + WTF::Function<void(void)> completionHandler = [this, shouldContinue] { WTF can be removed. This should probably also be a CompletionHandler.
Brady Eidson
Comment 5 2018-04-13 10:23:51 PDT
Created attachment 337904 [details] Patch
Brady Eidson
Comment 6 2018-04-13 10:31:06 PDT
Created attachment 337906 [details] Patch
WebKit Commit Bot
Comment 7 2018-04-13 11:04:28 PDT
Comment on attachment 337906 [details] Patch Clearing flags on attachment: 337906 Committed r230640: <https://trac.webkit.org/changeset/230640>
WebKit Commit Bot
Comment 8 2018-04-13 11:04:30 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-04-13 11:05:21 PDT
<rdar://problem/39417321>
Note You need to log in before you can comment on or make changes to this bug.