Bug 184558

Summary: Web Inspector: Refactoring: move popover styles from JS to CSS
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
bburg: review+
Patch
commit-queue: commit-queue-
Patch none

Nikita Vasilyev
Reported 2018-04-12 14:49:24 PDT
Introduce CSS variables to customize popover appearance in CSS and not JavaScript.
Attachments
Patch (8.95 KB, patch)
2018-04-12 14:57 PDT, Nikita Vasilyev 		bburg: review+
DetailsFormatted DiffDiff
Patch (8.95 KB, patch)
2018-04-12 15:22 PDT, Nikita Vasilyev 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
Patch (8.95 KB, patch)
2018-04-12 15:29 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nikita Vasilyev
Comment 1 2018-04-12 14:57:43 PDT
Created attachment 337840 [details] Patch
Blaze Burg
Comment 2 2018-04-12 15:18:40 PDT
Comment on attachment 337840 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337840&action=review r=me > Source/WebInspectorUI/UserInterface/Views/Popover.css:34 > + --popover-color: black; Nit: popover-text-color
Nikita Vasilyev
Comment 3 2018-04-12 15:22:44 PDT
Created attachment 337841 [details] Patch
WebKit Commit Bot
Comment 4 2018-04-12 15:23:35 PDT
Comment on attachment 337841 [details] Patch Rejecting attachment 337841 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 337841, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebInspectorUI/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/7298498
Nikita Vasilyev
Comment 5 2018-04-12 15:29:36 PDT
Created attachment 337842 [details] Patch
WebKit Commit Bot
Comment 6 2018-04-12 18:09:56 PDT
Comment on attachment 337842 [details] Patch Clearing flags on attachment: 337842 Committed r230618: <https://trac.webkit.org/changeset/230618>
WebKit Commit Bot
Comment 7 2018-04-12 18:09:57 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-04-12 18:10:21 PDT
<rdar://problem/39400882>
Note You need to log in before you can comment on or make changes to this bug.