Bug 184558 - Web Inspector: Refactoring: move popover styles from JS to CSS
Summary: Web Inspector: Refactoring: move popover styles from JS to CSS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-12 14:49 PDT by Nikita Vasilyev
Modified: 2018-04-12 18:10 PDT (History)
4 users (show)

See Also:

Attachments
Patch (8.95 KB, patch)
2018-04-12 14:57 PDT, Nikita Vasilyev 		bburg: review+
Details | Formatted Diff | Diff
Patch (8.95 KB, patch)
2018-04-12 15:22 PDT, Nikita Vasilyev 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch (8.95 KB, patch)
2018-04-12 15:29 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2018-04-12 14:49:24 PDT 
Introduce CSS variables to customize popover appearance in CSS and not JavaScript.
Comment 1 Nikita Vasilyev 2018-04-12 14:57:43 PDT 
Created attachment 337840 [details]
Patch
Comment 2 BJ Burg 2018-04-12 15:18:40 PDT 
Comment on attachment 337840 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337840&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/Popover.css:34
> +    --popover-color: black;

Nit: popover-text-color
Comment 3 Nikita Vasilyev 2018-04-12 15:22:44 PDT 
Created attachment 337841 [details]
Patch
Comment 4 WebKit Commit Bot 2018-04-12 15:23:35 PDT 
Comment on attachment 337841 [details]
Patch

Rejecting attachment 337841 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 337841, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebInspectorUI/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/7298498
Comment 5 Nikita Vasilyev 2018-04-12 15:29:36 PDT 
Created attachment 337842 [details]
Patch
Comment 6 WebKit Commit Bot 2018-04-12 18:09:56 PDT 
Comment on attachment 337842 [details]
Patch

Clearing flags on attachment: 337842

Committed r230618: <https://trac.webkit.org/changeset/230618>
Comment 7 WebKit Commit Bot 2018-04-12 18:09:57 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-04-12 18:10:21 PDT 
<rdar://problem/39400882>