Bug 184554

Summary: Implement checked cast for DDResultRef once DDResultGetCFTypeID() is available
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebCore Misc.Assignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, ddkilzer, jlewis3, joepeck, mmaxfield, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=186401
Attachments:
Description Flags
Patch
none
Patch v2
none
Patch v3 none

Description David Kilzer (:ddkilzer) 2018-04-12 13:03:07 PDT 
Implement checked cast for DDResultRef once DDResultGetTypeID() is available.
Comment 1 David Kilzer (:ddkilzer) 2018-04-12 13:03:15 PDT 
<rdar://problem/36241894>
Comment 2 David Kilzer (:ddkilzer) 2018-04-12 13:09:15 PDT 
Created attachment 337828 [details]
Patch
Comment 3 Brent Fulgham 2018-04-17 09:20:28 PDT 
Comment on attachment 337828 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337828&action=review

r=me

> Source/WebCore/editing/cocoa/DataDetection.mm:87
> +        DDResultRef result = checked_cf_cast<DDResultRef>(CFArrayGetValueAtIndex(results.get(), i));

Nice!
Comment 4 WebKit Commit Bot 2018-04-17 09:28:40 PDT 
Comment on attachment 337828 [details]
Patch

Clearing flags on attachment: 337828

Committed r230713: <https://trac.webkit.org/changeset/230713>
Comment 5 WebKit Commit Bot 2018-04-17 09:28:42 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Matt Lewis 2018-04-17 10:03:07 PDT 
Reverted r230713 for reason:

This caused internal build failures.

Committed r230716: <https://trac.webkit.org/changeset/230716>
Comment 7 David Kilzer (:ddkilzer) 2018-05-29 15:53:04 PDT 
Created attachment 341530 [details]
Patch v2
Comment 8 David Kilzer (:ddkilzer) 2018-05-29 15:55:27 PDT 
Created attachment 341531 [details]
Patch v3
Comment 9 David Kilzer (:ddkilzer) 2018-05-31 11:12:01 PDT 
(In reply to David Kilzer (:ddkilzer) from comment #8)
> Created attachment 341531 [details]
> Patch v3

Going to land v3 with Brent's previous review as I fixed the build failure on internal bots, and the patch is not materially different.
Comment 10 Brent Fulgham 2018-05-31 11:15:56 PDT 
Comment on attachment 341531 [details]
Patch v3

I still approve of this patch! r=me.
Comment 11 WebKit Commit Bot 2018-05-31 12:33:44 PDT 
Comment on attachment 341531 [details]
Patch v3

Clearing flags on attachment: 341531

Committed r232362: <https://trac.webkit.org/changeset/232362>
Comment 12 WebKit Commit Bot 2018-05-31 12:33:46 PDT 
All reviewed patches have been landed.  Closing bug.