Bug 184541

Summary: [Web Animations] Suspend animations when required
Product: WebKit Reporter: Antoine Quint <graouts>
Component: New BugsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dbates, esprehn+autocc, ews-watchlist, jonlee, kangil.han, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
jonlee: review+, jonlee: commit-queue-
Archive of layout-test-results from ews104 for mac-sierra-wk2
none
Archive of layout-test-results from ews123 for ios-simulator-wk2 none

Antoine Quint
Reported 2018-04-12 08:41:13 PDT
[Web Animations] Suspend animations when required
Attachments
Patch (24.76 KB, patch)
2018-04-12 08:50 PDT, Antoine Quint 		jonlee: review+
jonlee: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews104 for mac-sierra-wk2 (3.14 MB, application/zip)
2018-04-12 10:14 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (2.19 MB, application/zip)
2018-04-12 10:29 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2018-04-12 08:50:28 PDT
Created attachment 337800 [details] Patch
Jon Lee
Comment 2 2018-04-12 09:40:10 PDT
Comment on attachment 337800 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337800&action=review > Source/WebCore/ChangeLog:19 > + (WebCore::DocumentTimeline::numberOfActiveAnimations const): Called by Internals::numberOfActiveAnimations(), this I think we tend to name functions specific for internals with the "ForTesting" suffix. so: numberOfActiveAnimationsForTesting; to prevent accidental use by real code.
Antoine Quint
Comment 3 2018-04-12 09:47:41 PDT
(In reply to Jon Lee from comment #2) > Comment on attachment 337800 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=337800&action=review > > > Source/WebCore/ChangeLog:19 > > + (WebCore::DocumentTimeline::numberOfActiveAnimations const): Called by Internals::numberOfActiveAnimations(), this > > I think we tend to name functions specific for internals with the > "ForTesting" suffix. so: numberOfActiveAnimationsForTesting; to prevent > accidental use by real code. Cool! I'll make that change.
EWS Watchlist
Comment 4 2018-04-12 10:14:16 PDT
Comment on attachment 337800 [details] Patch Attachment 337800 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7294996 New failing tests: animations/added-while-suspended.html transitions/created-while-suspended.html
EWS Watchlist
Comment 5 2018-04-12 10:14:18 PDT
Created attachment 337805 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 6 2018-04-12 10:29:12 PDT
Comment on attachment 337800 [details] Patch Attachment 337800 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7295005 New failing tests: fast/animation/css-animation-resuming-when-visible-with-style-change2.html
EWS Watchlist
Comment 7 2018-04-12 10:29:13 PDT
Created attachment 337807 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Antoine Quint
Comment 8 2018-04-12 10:38:07 PDT
Committed r230581: <https://trac.webkit.org/changeset/230581>
Radar WebKit Bug Importer
Comment 9 2018-04-12 10:39:25 PDT
<rdar://problem/39385844>
Note You need to log in before you can comment on or make changes to this bug.