Bug 184539

Summary:

[Web Animations] Ensure elements overlapping with elements animating also get composited

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

New Bugs

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

jonlee, ryanhaddad, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	jonlee: review+

Description Antoine Quint 2018-04-12 08:25:25 PDT

[Web Animations] Ensure elements overlapping with elements animating also get composited

Comment 1 Antoine Quint 2018-04-12 08:32:45 PDT

Created attachment 337797 [details]
Patch

Comment 2 Jon Lee 2018-04-12 09:28:40 PDT

Comment on attachment 337797 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337797&action=review

> Source/WebCore/animation/DocumentTimeline.h:62
> +    // transform animation but we were unable to cheaply compute its affect on the extent.

effect*

Comment 3 Antoine Quint 2018-04-12 09:34:50 PDT

Committed r230578: <https://trac.webkit.org/changeset/230578>

Comment 4 Radar WebKit Bug Importer 2018-04-12 09:35:20 PDT

<rdar://problem/39383567>

Comment 5 Ryan Haddad 2018-04-12 10:12:35 PDT

(In reply to Antoine Quint from comment #3)
> Committed r230578: <https://trac.webkit.org/changeset/230578>
This change broke the Windows build:

c:\cygwin\home\buildbot\slave\win-release\build\source\webcore\animation\documenttimeline.cpp(208): error C2220: warning treated as error - no 'object' file generated [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
c:\cygwin\home\buildbot\slave\win-release\build\source\webcore\animation\documenttimeline.cpp(208): warning C4701: potentially uninitialized local variable 'matchingEffect' used [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
c:\cygwin\home\buildbot\slave\win-release\build\source\webcore\animation\documenttimeline.cpp(208): warning C4703: potentially uninitialized local pointer variable 'matchingEffect' used [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]


https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/8766

Comment 6 Antoine Quint 2018-04-12 10:42:07 PDT

Windows build should be fixed by https://trac.webkit.org/changeset/230582.